Changeset 6316 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/HistoryDialog.java

Timestamp:

2013-10-07T20:18:17+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Loose coupling

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/HistoryDialog.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/HistoryDialog.java

@@ -62 +62 @@
     protected ReloadAction reloadAction;
 
+    /**
+     * Constructs a new {@code HistoryDialog}.
+     */
     public HistoryDialog() {
         super(tr("History"), "history", tr("Display the history of all selected items."),
@@ -149 +152 @@
      */
     static class HistoryItemTableModel extends DefaultTableModel implements SelectionChangedListener{
-        private ArrayList<OsmPrimitive> data;
+        private List<OsmPrimitive> data;
         private DefaultListSelectionModel selectionModel;
 
@@ -175 +178 @@
 
         protected List<OsmPrimitive> getSelectedPrimitives() {
-            ArrayList<OsmPrimitive> ret = new ArrayList<OsmPrimitive>();
+            List<OsmPrimitive> ret = new ArrayList<OsmPrimitive>();
             for (int i=0; i< data.size(); i++) {
                 if (selectionModel.isSelectedIndex(i)) {
@@ -227 +230 @@
         public List<OsmPrimitive> getPrimitives(int [] rows) {
             if (rows == null || rows.length == 0) return Collections.emptyList();
-            ArrayList<OsmPrimitive> ret = new ArrayList<OsmPrimitive>(rows.length);
+            List<OsmPrimitive> ret = new ArrayList<OsmPrimitive>(rows.length);
             for (int row: rows) {
                 ret.add(data.get(row));