Changeset 6316 in josm for trunk/src/org/openstreetmap/josm/actions/AlignInLineAction.java

Timestamp:

2013-10-07T20:18:17+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Loose coupling

File:

• trunk/src/org/openstreetmap/josm/actions/AlignInLineAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/AlignInLineAction.java

@@ -32 +32 @@
 public final class AlignInLineAction extends JosmAction {
 
+    /**
+     * Constructs a new {@code AlignInLineAction}.
+     */
     public AlignInLineAction() {
         super(tr("Align Nodes in Line"), "alignline", tr("Move the selected nodes in to a line."),
@@ -39 +42 @@
 
     // the joy of single return values only...
-    private void nodePairFurthestApart(ArrayList<Node> nodes, Node[] resultOut) {
+    private void nodePairFurthestApart(List<Node> nodes, Node[] resultOut) {
         if(resultOut.length < 2)
             throw new IllegalArgumentException();
@@ -107 +110 @@
         List<Node> selectedNodes = new ArrayList<Node>(getCurrentDataSet().getSelectedNodes());
         Collection<Way> selectedWays = getCurrentDataSet().getSelectedWays();
-        ArrayList<Node> nodes = new ArrayList<Node>();
+        List<Node> nodes = new ArrayList<Node>();
 
         //// Decide what to align based on selection: