Changeset 6310 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2013-10-07T00:04:48+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Nested blocks of code should not be left empty

Location:

trunk/src/org/openstreetmap/josm/plugins

Files:

• PluginInformation.java (modified) (1 diff)
• PluginProxy.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

@@ -210 +210 @@
         stage = stageStr == null ? 50 : Integer.parseInt(stageStr);
         version = attr.getValue("Plugin-Version");
-        try { mainversion = Integer.parseInt(attr.getValue("Plugin-Mainversion")); }
-        catch(NumberFormatException e) {}
+        try {
+            mainversion = Integer.parseInt(attr.getValue("Plugin-Mainversion"));
+        } catch(NumberFormatException e) {
+            Main.warn(e);
+        }
         author = attr.getValue("Author");
         iconPath = attr.getValue("Plugin-Icon");

trunk/src/org/openstreetmap/josm/plugins/PluginProxy.java

@@ -4 +4 @@
 import java.util.List;
 
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.download.DownloadSelection;
@@ -29 +30 @@
             plugin.getClass().getMethod("mapFrameInitialized", MapFrame.class, MapFrame.class).invoke(plugin, oldFrame, newFrame);
         } catch (NoSuchMethodException e) {
+            Main.debug("Plugin "+plugin+" does not define mapFrameInitialized");
         } catch (Exception e) {
             BugReportExceptionHandler.handleException(new PluginException(this, getPluginInformation().name, e));
@@ -38 +40 @@
             return (PreferenceSetting)plugin.getClass().getMethod("getPreferenceSetting").invoke(plugin);
         } catch (NoSuchMethodException e) {
+            Main.debug("Plugin "+plugin+" does not define getPreferenceSetting");
             return null;
         } catch (Exception e) {
@@ -49 +52 @@
             plugin.getClass().getMethod("addDownloadSelection", List.class).invoke(plugin, list);
         } catch (NoSuchMethodException e) {
-            // ignore
+            Main.debug("Plugin "+plugin+" does not define addDownloadSelection");
         } catch (Exception e) {
             BugReportExceptionHandler.handleException(new PluginException(this, getPluginInformation().name, e));