Changeset 6268 in josm for trunk/src/org/openstreetmap/josm/io/OsmApi.java

Timestamp:

2013-09-27T19:50:29+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Bad practice - Method may fail to close stream

File:

• trunk/src/org/openstreetmap/josm/io/OsmApi.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/io/OsmApi.java

@@ -621 +621 @@
                     if (requestBody != null) {
                         BufferedWriter bwr = new BufferedWriter(new OutputStreamWriter(out, "UTF-8"));
-                        bwr.write(requestBody);
-                        bwr.flush();
+                        try {
+                            bwr.write(requestBody);
+                            bwr.flush();
+                        } finally {
+                            bwr.close();
+                        }
                     }
                     Utils.close(out);
@@ -657 +661 @@
                     BufferedReader in = new BufferedReader(new InputStreamReader(i));
                     String s;
-                    while((s = in.readLine()) != null) {
-                        responseBody.append(s);
-                        responseBody.append("\n");
+                    try {
+                        while((s = in.readLine()) != null) {
+                            responseBody.append(s);
+                            responseBody.append("\n");
+                        }
+                    } finally {
+                        in.close();
                     }
                 }