Changeset 6264 in josm for trunk/src/org/openstreetmap/josm/data/validation/util/MultipleNameVisitor.java

Timestamp:

2013-09-27T01:16:28+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Performance - Method concatenates strings using + in a loop

File:

• trunk/src/org/openstreetmap/josm/data/validation/util/MultipleNameVisitor.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/util/MultipleNameVisitor.java

@@ -33 +33 @@
      */
     public void visit(Collection<? extends OsmPrimitive> data) {
-        String multipleName = "";
+        StringBuilder multipleName = new StringBuilder();
         String multiplePluralClassname = null;
         size = data.size();
@@ -44 +44 @@
             }
             if (name != null && !name.isEmpty() && multipleName.length() <= MULTIPLE_NAME_MAX_LENGTH) {
-                if (!multipleName.isEmpty()) {
-                    multipleName += ", ";
+                if (multipleName.length() > 0) {
+                    multipleName.append(", ");
                 }
-                multipleName += name;
+                multipleName.append(name);
             }
 
@@ -64 +64 @@
         } else {
             displayName = size + " " + trn(multipleClassname, multiplePluralClassname, size);
-            if (!multipleName.isEmpty()) {
+            if (multipleName.length() > 0) {
                 if (multipleName.length() <= MULTIPLE_NAME_MAX_LENGTH) {
                     displayName += ": " + multipleName;