Changeset 6264 in josm for trunk/src/org/openstreetmap/josm/data/osm/history/History.java

Timestamp:

2013-09-27T01:16:28+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Performance - Method concatenates strings using + in a loop

File:

• trunk/src/org/openstreetmap/josm/data/osm/history/History.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/history/History.java

@@ -241 +241 @@
     @Override
     public String toString() {
-        String result = "History ["
-                + (type != null ? "type=" + type + ", " : "") + "id=" + id;
+        StringBuilder result = new StringBuilder("History ["
+                + (type != null ? "type=" + type + ", " : "") + "id=" + id);
         if (versions != null) {
-            result += ", versions=\n";
+            result.append(", versions=\n");
             for (HistoryOsmPrimitive v : versions) {
-                result += "\t" + v + ",\n";
+                result.append("\t").append(v).append(",\n");
             }
         }
-        result += "]";
-        return result;
+        result.append("]");
+        return result.toString();
     }
 }