Changeset 6258 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2013-09-25T02:56:42+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/Findbugs - Performance - Inefficient use of keySet iterator instead of entrySet iterator

File:

• trunk/src/org/openstreetmap/josm/tools/TextTagParser.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/tools/TextTagParser.java

@@ -9 +9 @@
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -232 +233 @@
      */
     public static boolean validateTags(Map<String, String> tags) {
-        String value;
         int r;
         int s = tags.size();
@@ -242 +242 @@
             if (r==2 || r==3) return false; if (r==4) return true;
         }
-        for (String key: tags.keySet()) {
-            value = tags.get(key);
+        for (Entry<String, String> entry : tags.entrySet()) {
+            String key = entry.getKey();
+            String value = entry.getValue();
             if (key.length() > MAX_KEY_LENGTH) {
                 r = warning(tr("Key is too long (max {0} characters):", MAX_KEY_LENGTH), key+"="+value, "tags.paste.keytoolong");