Changeset 5889 in josm for trunk/src/org/openstreetmap/josm/io/auth

Timestamp:

2013-04-20T15:50:18+02:00 (11 years ago)

Author:

Don-vip

Message:

fix potential bugs detected by FindBugs

File:

• trunk/src/org/openstreetmap/josm/io/auth/AbstractCredentialsAgent.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/auth/AbstractCredentialsAgent.java

@@ -50 +50 @@
                 public void run() {
                     CredentialDialog dialog = null;
-                    switch(requestorType) {
-                    case SERVER: dialog = CredentialDialog.getOsmApiCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText()); break;
-                    case PROXY: dialog = CredentialDialog.getHttpProxyCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText()); break;
-                    }
+                    if (requestorType.equals(RequestorType.PROXY))
+                        dialog = CredentialDialog.getHttpProxyCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText());
+                    else 
+                        dialog = CredentialDialog.getOsmApiCredentialDialog(username, password, host, getSaveUsernameAndPasswordCheckboxText());
                     dialog.setVisible(true);
                     response.setCanceled(dialog.isCanceled());