Changeset 4710 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2011-12-26T12:57:26+01:00 (12 years ago)

Author:

bastiK

Message:

fixed NPE from [4695] (see #7153)

File:

• trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java

@@ -70 +70 @@
 
     public MarkerLayer(GpxData indata, String name, File associatedFile, GpxLayer fromLayer) {
-
+        this(indata, name, associatedFile, fromLayer, true);
+    }
+
+    public MarkerLayer(GpxData indata, String name, File associatedFile, GpxLayer fromLayer, boolean addMouseHandlerInConstructor) {
         super(name);
         this.setAssociatedFile(associatedFile);
@@ -88 +91 @@
         }
 
-        SwingUtilities.invokeLater(new Runnable(){
-            public void run() {
-                Main.map.mapView.addMouseListener(new MouseAdapter() {
-                    @Override public void mousePressed(MouseEvent e) {
-                        if (e.getButton() != MouseEvent.BUTTON1)
-                            return;
-                        boolean mousePressedInButton = false;
-                        if (e.getPoint() != null) {
-                            for (Marker mkr : data) {
-                                if (mkr.containsPoint(e.getPoint())) {
-                                    mousePressedInButton = true;
-                                    break;
-                                }
-                            }
-                        }
-                        if (! mousePressedInButton)
-                            return;
-                        mousePressed  = true;
-                        if (isVisible()) {
-                            Main.map.mapView.repaint();
+        if (addMouseHandlerInConstructor) {
+            SwingUtilities.invokeLater(new Runnable(){
+                public void run() {
+                    addMouseHandler();
+                }
+            });
+        }
+    }
+
+    public void addMouseHandler() {
+        Main.map.mapView.addMouseListener(new MouseAdapter() {
+            @Override public void mousePressed(MouseEvent e) {
+                if (e.getButton() != MouseEvent.BUTTON1)
+                    return;
+                boolean mousePressedInButton = false;
+                if (e.getPoint() != null) {
+                    for (Marker mkr : data) {
+                        if (mkr.containsPoint(e.getPoint())) {
+                            mousePressedInButton = true;
+                            break;
                         }
                     }
-                    @Override public void mouseReleased(MouseEvent ev) {
-                        if (ev.getButton() != MouseEvent.BUTTON1 || ! mousePressed)
-                            return;
-                        mousePressed = false;
-                        if (!isVisible())
-                            return;
-                        if (ev.getPoint() != null) {
-                            for (Marker mkr : data) {
-                                if (mkr.containsPoint(ev.getPoint())) {
-                                    mkr.actionPerformed(new ActionEvent(this, 0, null));
-                                }
-                            }
+                }
+                if (! mousePressedInButton)
+                    return;
+                mousePressed  = true;
+                if (isVisible()) {
+                    Main.map.mapView.repaint();
+                }
+            }
+            @Override public void mouseReleased(MouseEvent ev) {
+                if (ev.getButton() != MouseEvent.BUTTON1 || ! mousePressed)
+                    return;
+                mousePressed = false;
+                if (!isVisible())
+                    return;
+                if (ev.getPoint() != null) {
+                    for (Marker mkr : data) {
+                        if (mkr.containsPoint(ev.getPoint())) {
+                            mkr.actionPerformed(new ActionEvent(this, 0, null));
                         }
-                        Main.map.mapView.repaint();
                     }
-                });
+                }
+                Main.map.mapView.repaint();
             }
         });