Changeset 4481 in josm for trunk/src/org/openstreetmap/josm/data/validation

Timestamp:

2011-10-01T14:23:58+02:00 (13 years ago)

Author:

simon04

Message:

fix #6911 - "Crossing ways" warning for ways waterway=riverbank and waterway=river

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/CrossingWays.java

@@ -74 +74 @@
         boolean isTram1 = "tram".equals(railway1);
         boolean isBuilding = (w.get("building") != null);
+        String waterway1 = w.get("waterway");
 
         if (w.get("highway") == null && w.get("waterway") == null
@@ -86 +87 @@
         for (int i = 0; i < nodesSize - 1; i++) {
             WaySegment ws = new WaySegment(w, i);
-            ExtendedSegment es1 = new ExtendedSegment(ws, layer1, railway1, isCoastline1);
+            ExtendedSegment es1 = new ExtendedSegment(ws, layer1, railway1, isCoastline1, waterway1);
             List<List<ExtendedSegment>> cellSegments = getSegments(es1.n1, es1.n2);
             for (List<ExtendedSegment> segments : cellSegments) {
@@ -107 +108 @@
 
                     if (isCoastline1 != isCoastline2) continue;
+                    if (("river".equals(waterway1) && "riverbank".equals(es2.waterway))
+                            || ("riverbank".equals(waterway1) && "river".equals(es2.waterway))) continue;
 
                     if ((es1.railway != null && es1.railway.equals("abandoned"))
@@ -170 +173 @@
         public String railway;
 
+        /** The waterway type */
+        public String waterway;
+
         /** The coastline type */
         public boolean coastline;
@@ -179 +185 @@
          * @param railway The railway type of the way this segment is in
          * @param coastline The coastline flag of the way the segment is in
+         * @param waterway The waterway type of the way this segment is in
          */
-        public ExtendedSegment(WaySegment ws, String layer, String railway, boolean coastline) {
+        public ExtendedSegment(WaySegment ws, String layer, String railway, boolean coastline, String waterway) {
             this.ws = ws;
             this.n1 = ws.way.getNodes().get(ws.lowerIndex);
@@ -187 +194 @@
             this.railway = railway;
             this.coastline = coastline;
+            this.waterway = waterway;
         }