Changeset 3709 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2010-12-08T22:33:58+01:00 (13 years ago)

Author:

bastiK

Message:

slight change in preference: getCollection(key, def) always remembers default, even if def == null (to be consistent with get(key, def). (this shouldn't break anything, but you never know...)

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -616 +616 @@
     }
 
+    /**
+     * Get a list of values for a certain key
+     * @param key the identifier for the setting
+     * @param def the default value.
+     * @return the corresponding value if the property has been set before,
+     *  def otherwise
+     */
     synchronized public Collection<String> getCollection(String key, Collection<String> def) {
+        putCollectionDefault(key, def);
         String s = get(key);
-        if(def != null)
-            putCollectionDefault(key, def);
         if(s != null && s.length() != 0)
             return Arrays.asList(s.split("\u001e"));
@@ -651 +657 @@
     
     synchronized private void putCollectionDefault(String key, Collection<String> val) {
-        String s = null;
-        for(String a : val)
-        {
-            if(s != null) {
-                s += "\u001e" + a;
-            } else {
-                s = a;
-            }
-        }
-        putDefault(key, s);
+        if (val == null) {
+            putDefault(key, null);
+        } else {
+            String s = null;
+            for(String a : val)
+            {
+                if(s != null) {
+                    s += "\u001e" + a;
+                } else {
+                    s = a;
+                }
+            }
+            putDefault(key, s);
+        }
     }