Index: /applications/editors/josm/plugins/FixAddresses/.settings/org.eclipse.jdt.core.prefs =================================================================== --- /applications/editors/josm/plugins/FixAddresses/.settings/org.eclipse.jdt.core.prefs (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/.settings/org.eclipse.jdt.core.prefs (revision 34880) @@ -16,4 +16,5 @@ org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.doc.comment.support=enabled org.eclipse.jdt.core.compiler.problem.APILeak=warning org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning @@ -40,4 +41,9 @@ org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore +org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning +org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning @@ -46,4 +52,12 @@ org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore +org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore +org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public +org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=all_standard_tags +org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=private org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled @@ -84,5 +98,5 @@ org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore -org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=ignore org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentType=warning org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentTypeStrict=disabled @@ -106,5 +120,5 @@ org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore -org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=ignore org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.8 Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressEditContainer.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressEditContainer.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressEditContainer.java (revision 34880) @@ -26,4 +26,6 @@ import org.openstreetmap.josm.gui.MainApplication; import org.openstreetmap.josm.gui.layer.MainLayerManager; +import org.openstreetmap.josm.plugins.fixAddresses.gui.AddressEditTableModel; +import org.openstreetmap.josm.plugins.fixAddresses.gui.actions.AbstractAddressEditAction; import org.openstreetmap.josm.tools.CheckParameterUtil; @@ -38,11 +40,11 @@ * and alter OSM data. * - * {@see AbstractAddressEditAction} - * {@see AddressEditTableModel} - * * @author Oliver Wieland <oliver.wieland@online.de> * + * @see AbstractAddressEditAction + * @see AddressEditTableModel */ -public class AddressEditContainer implements OsmPrimitiveVisitor, DataSetListener, IAddressEditContainerListener, IProblemVisitor, IAllKnowingTrashHeap { +public class AddressEditContainer +implements OsmPrimitiveVisitor, DataSetListener, IAddressEditContainerListener, IProblemVisitor, IAllKnowingTrashHeap { private Collection workingSet; @@ -125,4 +127,5 @@ /** * Notifies clients that an entity within the address container changed. + * @param entity OSM entity */ protected void fireEntityChanged(IOSMEntity entity) { @@ -442,4 +445,5 @@ * Tries to assign an address to a street. * @param aNode address + * @return {@code true} if address node has been assigned to a street or if it was already the case */ private boolean assignAddressToStreet(OSMAddress aNode) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressProblem.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressProblem.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/AddressProblem.java (revision 34880) @@ -7,4 +7,7 @@ import org.openstreetmap.josm.tools.CheckParameterUtil; +/** + * Address problem. + */ public class AddressProblem implements IProblem { private List solutions = null; Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesMapMode.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesMapMode.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesMapMode.java (revision 34880) @@ -8,4 +8,7 @@ import org.openstreetmap.josm.actions.mapmode.MapMode; +/** + * Map mode that shows dialog with incomplete addresses + */ @SuppressWarnings("serial") public class FixAddressesMapMode extends MapMode { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesPreferences.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesPreferences.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/FixAddressesPreferences.java (revision 34880) @@ -13,4 +13,7 @@ import org.openstreetmap.josm.spi.preferences.Config; +/** + * Plugin preferences. + */ public final class FixAddressesPreferences extends DefaultTabPreferenceSetting { private static final String FIX_ADDRESSES_IGNORE_POST_CODE_KEY = "fixAddresses.ignorePostCode"; Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessAddressRunnable.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessAddressRunnable.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessAddressRunnable.java (revision 34880) @@ -22,5 +22,5 @@ * The guessing procedure itself is implemented by defining "guessers" using the {@link GuessedValueHandler} * class. A guessed field does not modify the corresponding property of {@link OSMAddress} itself, but - * adds the guessed value to a shadowed field by calling {@link OSMAddress#setGuessedValue(String, String)}. + * adds the guessed value to a shadowed field by calling {@link OSMAddress#setGuessedValue}. */ public class GuessAddressRunnable extends PleaseWaitRunnable { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessedValueHandler.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessedValueHandler.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/GuessedValueHandler.java (revision 34880) @@ -47,9 +47,8 @@ /** - * Instantiates a new guessed value handler. + * Instantiates a new guessed value handler with default maximum distance. * * @param tag the tag to find the guessed value for. * @param aNode the address node to guess the values for. - * @param maxDist the maximum distance for a node/way to be considered as guessed value. */ public GuessedValueHandler(String tag, OSMAddress aNode) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAddressEditContainerListener.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAddressEditContainerListener.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAddressEditContainerListener.java (revision 34880) @@ -2,4 +2,7 @@ package org.openstreetmap.josm.plugins.fixAddresses; +/** + * Address edit container listener. + */ public interface IAddressEditContainerListener { /** @@ -11,4 +14,5 @@ /** * Notifies clients that an entity has been changed. + * @param node OSM entity */ void entityChanged(IOSMEntity node); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAllKnowingTrashHeap.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAllKnowingTrashHeap.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IAllKnowingTrashHeap.java (revision 34880) @@ -4,4 +4,7 @@ import java.util.List; +/** + * Knowledge of street names distances and validity. + */ public interface IAllKnowingTrashHeap { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ICommandListener.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ICommandListener.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ICommandListener.java (revision 34880) @@ -4,4 +4,7 @@ import org.openstreetmap.josm.command.Command; +/** + * Command listener. + */ public interface ICommandListener { /** Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblem.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblem.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblem.java (revision 34880) @@ -4,4 +4,7 @@ import java.util.List; +/** + * Generic problem. + */ public interface IProblem { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblemVisitor.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblemVisitor.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProblemVisitor.java (revision 34880) @@ -2,4 +2,7 @@ package org.openstreetmap.josm.plugins.fixAddresses; +/** + * Problem visitor. + */ public interface IProblemVisitor { /** @@ -12,4 +15,5 @@ /** * Removes the problems of the given source. + * @param entity OSM entity */ void removeProblemsOfSource(IOSMEntity entity); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProgressMonitorFinishedListener.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProgressMonitorFinishedListener.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/IProgressMonitorFinishedListener.java (revision 34880) @@ -2,4 +2,7 @@ package org.openstreetmap.josm.plugins.fixAddresses; +/** + * Progress monitor listener for the finished state. + */ public interface IProgressMonitorFinishedListener { void finished(); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ISolution.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ISolution.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ISolution.java (revision 34880) @@ -4,4 +4,7 @@ import org.openstreetmap.josm.actions.JosmAction; +/** + * Generic solution to a {@link IProblem}. + */ public interface ISolution { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMAddress.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMAddress.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMAddress.java (revision 34880) @@ -95,14 +95,14 @@ || StringUtils.isNullOrEmpty(osmObject.get(tag))) { if (!hasDerivedValue(tag)) { - // object does not have this tag -> check for guess - if (hasGuessedValue(tag)) { - return "*" + getGuessedValue(tag); - } else { - // give up - return MISSING_TAG; - } + // object does not have this tag -> check for guess + if (hasGuessedValue(tag)) { + return "*" + getGuessedValue(tag); + } else { + // give up + return MISSING_TAG; + } } else { // ok, use derived value known via associated relation or - // way - return getDerivedValue(tag); + // way + return getDerivedValue(tag); } } else { // get existing tag value @@ -429,29 +429,28 @@ cc = this.getStreetName().compareTo(other.getStreetName()); if (cc == 0) { - if (hasGuessedStreetName()) { - if (other.hasStreetName()) { - // Compare guessed name with the real name - /*String gsm =*/ this.getGuessedStreetName(); - cc = this.getGuessedStreetName().compareTo( - other.getStreetName()); - if (cc == 0) { + if (hasGuessedStreetName()) { + if (other.hasStreetName()) { + // Compare guessed name with the real name + /*String gsm =*/ this.getGuessedStreetName(); + cc = this.getGuessedStreetName().compareTo( + other.getStreetName()); + if (cc == 0) { + cc = this.getHouseNumber().compareTo( + other.getHouseNumber()); + } + } else if (other.hasGuessedStreetName()) { + // Compare guessed name with the guessed name + cc = this.getGuessedStreetName().compareTo( + other.getGuessedStreetName()); + if (cc == 0) { + cc = this.getHouseNumber().compareTo( + other.getHouseNumber()); + } + } // else: give up + // No guessed name at all -> just compare the number + } else { cc = this.getHouseNumber().compareTo( other.getHouseNumber()); } - } else if (other.hasGuessedStreetName()) { - // Compare guessed name with the guessed name - cc = this.getGuessedStreetName().compareTo( - other.getGuessedStreetName()); - if (cc == 0) { - cc = this.getHouseNumber().compareTo( - other.getHouseNumber()); - } - } // else: give up - // No guessed name at all -> just compare the - // number - } else { - cc = this.getHouseNumber().compareTo( - other.getHouseNumber()); - } } } @@ -539,4 +538,5 @@ /** * Check if this instance needs guessed value for a given tag. + * @param tag tag to analyze * * @return true, if successful Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMEntityBase.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMEntityBase.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OSMEntityBase.java (revision 34880) @@ -66,4 +66,5 @@ /** * Notifies clients that the address container changed. + * @param entity OSM entity */ protected static void fireEntityChanged(IOSMEntity entity) { @@ -97,5 +98,4 @@ * Notifies clients that an entity has issued a command. * - * @param source the entity that issued the command. * @param command the command to execute. */ @@ -140,9 +140,8 @@ /** * Internal helper method which changes the given property and - * puts the appropriate command {@link src.org.openstreetmap.josm.command.Command} + * puts the appropriate command {@link org.openstreetmap.josm.command.Command} * into the undo/redo queue. * @param tag The tag to change. * @param newValue The new value for the tag. - * @param cmd The surrounding command sequence */ protected void setOSMTag(String tag, String newValue) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OsmFactory.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OsmFactory.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/OsmFactory.java (revision 34880) @@ -7,4 +7,7 @@ import org.openstreetmap.josm.data.osm.Way; +/** + * OSM entities factory. + */ public final class OsmFactory { private static HashMap addressCache = new HashMap<>(); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ProblemType.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ProblemType.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/ProblemType.java (revision 34880) @@ -2,4 +2,7 @@ package org.openstreetmap.josm.plugins.fixAddresses; +/** + * Problem type (severity). + */ public enum ProblemType { Warning, Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/StringUtils.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/StringUtils.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/StringUtils.java (revision 34880) @@ -4,4 +4,7 @@ import java.util.List; +/** + * Various String utilities. + */ public final class StringUtils { @@ -18,5 +21,5 @@ */ public static boolean isNullOrEmpty(String txt) { - return txt == null || txt.length() == 0; + return txt == null || txt.isEmpty(); } @@ -30,6 +33,6 @@ * @return The length of the longest common substring or 0, if no common * sequence exists or one of the arguments are invalid. For - * algorithm details please refer to {@link http - * ://www.ics.uci.edu/~eppstein/161/960229.html} + * algorithm details please refer to + * ICS 161: Design and Analysis of Algorithms */ public static int lcsLength(String a, String b) { @@ -43,7 +46,4 @@ } - /** - * Internal use only - */ private static int[][] createLCSTable(String a, String b) { if (StringUtils.isNullOrEmpty(a)) @@ -124,5 +124,5 @@ return null; } - if (haystack == null || haystack.size() == 0) { + if (haystack == null || haystack.isEmpty()) { return null; } Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/TagUtils.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/TagUtils.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/TagUtils.java (revision 34880) @@ -128,4 +128,5 @@ /** * Checks if the given OSM primitive is an address node. + * @param osmObject OSM primitive * @return {@code true} if the given OSM primitive is an address node */ @@ -139,4 +140,5 @@ * Check if OSM primitive has a tag 'parking'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'parking' */ public static boolean hasParkingTag(OsmPrimitive osmPrimitive) { @@ -147,4 +149,5 @@ * Gets the value of tag 'parking'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'parking' */ public static String getParkingValue(OsmPrimitive osmPrimitive) { @@ -155,4 +158,5 @@ * Check if OSM primitive has a tag 'shop'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'shop' */ public static boolean hasShopTag(OsmPrimitive osmPrimitive) { @@ -163,4 +167,5 @@ * Gets the value of tag 'shop'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'shop' */ public static String getShopValue(OsmPrimitive osmPrimitive) { @@ -171,4 +176,5 @@ * Check if OSM primitive has a tag 'craft'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'craft' */ public static boolean hasCraftTag(OsmPrimitive osmPrimitive) { @@ -179,4 +185,5 @@ * Gets the value of tag 'craft'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'craft' */ public static String getCraftValue(OsmPrimitive osmPrimitive) { @@ -187,4 +194,5 @@ * Check if OSM primitive has a tag 'surface'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'surface' */ public static boolean hasSurfaceTag(OsmPrimitive osmPrimitive) { @@ -195,4 +203,5 @@ * Gets the value of tag 'surface'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'surface' */ public static String getSurfaceValue(OsmPrimitive osmPrimitive) { @@ -203,4 +212,5 @@ * Check if OSM primitive has a tag 'cuisine'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'cuisine' */ public static boolean hasCuisineTag(OsmPrimitive osmPrimitive) { @@ -211,4 +221,5 @@ * Gets the value of tag 'cuisine'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'cuisine' */ public static String getCuisineValue(OsmPrimitive osmPrimitive) { @@ -219,4 +230,5 @@ * Check if OSM primitive has a tag 'wood'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'wood' */ public static boolean hasWoodTag(OsmPrimitive osmPrimitive) { @@ -227,4 +239,5 @@ * Gets the value of tag 'wood'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'wood' */ public static String getWoodValue(OsmPrimitive osmPrimitive) { @@ -235,4 +248,5 @@ * Check if OSM primitive has a tag 'foot'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'foot' */ public static boolean hasFootTag(OsmPrimitive osmPrimitive) { @@ -243,4 +257,5 @@ * Gets the value of tag 'foot'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'foot' */ public static String getFootValue(OsmPrimitive osmPrimitive) { @@ -251,4 +266,5 @@ * Check if OSM primitive has a tag 'name:de'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'name:de' */ public static boolean hasNameDeTag(OsmPrimitive osmPrimitive) { @@ -259,4 +275,5 @@ * Gets the value of tag 'name:de'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'name:de' */ public static String getNameDeValue(OsmPrimitive osmPrimitive) { @@ -267,4 +284,5 @@ * Check if OSM primitive has a tag 'nat_ref'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'nat_ref' */ public static boolean hasNatRefTag(OsmPrimitive osmPrimitive) { @@ -275,4 +293,5 @@ * Gets the value of tag 'nat_ref'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'nat_ref' */ public static String getNatRefValue(OsmPrimitive osmPrimitive) { @@ -283,4 +302,5 @@ * Check if OSM primitive has a tag 'note:de'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'note:de' */ public static boolean hasNoteDeTag(OsmPrimitive osmPrimitive) { @@ -291,4 +311,5 @@ * Gets the value of tag 'note:de'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'note:de' */ public static String getNoteDeValue(OsmPrimitive osmPrimitive) { @@ -299,4 +320,5 @@ * Check if OSM primitive has a tag 'addr:street'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:street' */ public static boolean hasAddrStreetTag(OsmPrimitive osmPrimitive) { @@ -308,4 +330,5 @@ * Gets the value of tag 'addr:street'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:street' */ public static String getAddrStreetValue(OsmPrimitive osmPrimitive) { @@ -316,4 +339,5 @@ * Check if OSM primitive has a tag 'type'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'type' */ public static boolean hasTypeTag(OsmPrimitive osmPrimitive) { @@ -324,4 +348,5 @@ * Gets the value of tag 'type'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'type' */ public static String getTypeValue(OsmPrimitive osmPrimitive) { @@ -332,4 +357,5 @@ * Check if OSM primitive has a tag 'addr:city'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:city' */ public static boolean hasAddrCityTag(OsmPrimitive osmPrimitive) { @@ -341,4 +367,5 @@ * Gets the value of tag 'addr:city'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:city' */ public static String getAddrCityValue(OsmPrimitive osmPrimitive) { @@ -349,4 +376,5 @@ * Check if OSM primitive has a tag 'boundary'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'boundary' */ public static boolean hasBoundaryTag(OsmPrimitive osmPrimitive) { @@ -357,4 +385,5 @@ * Gets the value of tag 'boundary'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'boundary' */ public static String getBoundaryValue(OsmPrimitive osmPrimitive) { @@ -365,4 +394,5 @@ * Check if OSM primitive has a tag 'smoothness'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'smoothness' */ public static boolean hasSmoothnessTag(OsmPrimitive osmPrimitive) { @@ -374,4 +404,5 @@ * Gets the value of tag 'smoothness'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'smoothness' */ public static String getSmoothnessValue(OsmPrimitive osmPrimitive) { @@ -382,4 +413,5 @@ * Check if OSM primitive has a tag 'opening_hours'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'opening_hours' */ public static boolean hasOpeningHoursTag(OsmPrimitive osmPrimitive) { @@ -391,4 +423,5 @@ * Gets the value of tag 'opening_hours'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'opening_hours' */ public static String getOpeningHoursValue(OsmPrimitive osmPrimitive) { @@ -400,4 +433,5 @@ * Check if OSM primitive has a tag 'bicycle'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'bicycle' */ public static boolean hasBicycleTag(OsmPrimitive osmPrimitive) { @@ -408,4 +442,5 @@ * Gets the value of tag 'bicycle'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'bicycle' */ public static String getBicycleValue(OsmPrimitive osmPrimitive) { @@ -416,4 +451,5 @@ * Check if OSM primitive has a tag 'religion'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'religion' */ public static boolean hasReligionTag(OsmPrimitive osmPrimitive) { @@ -424,4 +460,5 @@ * Gets the value of tag 'religion'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'religion' */ public static String getReligionValue(OsmPrimitive osmPrimitive) { @@ -432,4 +469,5 @@ * Check if OSM primitive has a tag 'barrier'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'barrier' */ public static boolean hasBarrierTag(OsmPrimitive osmPrimitive) { @@ -440,4 +478,5 @@ * Gets the value of tag 'barrier'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'barrier' */ public static String getBarrierValue(OsmPrimitive osmPrimitive) { @@ -448,4 +487,5 @@ * Check if OSM primitive has a tag 'power'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'power' */ public static boolean hasPowerTag(OsmPrimitive osmPrimitive) { @@ -456,4 +496,5 @@ * Gets the value of tag 'power'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'power' */ public static String getPowerValue(OsmPrimitive osmPrimitive) { @@ -464,4 +505,5 @@ * Check if OSM primitive has a tag 'landuse'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'landuse' */ public static boolean hasLanduseTag(OsmPrimitive osmPrimitive) { @@ -472,4 +514,5 @@ * Gets the value of tag 'landuse'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'landuse' */ public static String getLanduseValue(OsmPrimitive osmPrimitive) { @@ -480,4 +523,5 @@ * Check if OSM primitive has a tag 'fireplace'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'fireplace' */ public static boolean hasFireplaceTag(OsmPrimitive osmPrimitive) { @@ -489,4 +533,5 @@ * Gets the value of tag 'fireplace'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'fireplace' */ public static String getFireplaceValue(OsmPrimitive osmPrimitive) { @@ -497,4 +542,5 @@ * Check if OSM primitive has a tag 'int_ref'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'int_ref' */ public static boolean hasIntRefTag(OsmPrimitive osmPrimitive) { @@ -505,4 +551,5 @@ * Gets the value of tag 'int_ref'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'int_ref' */ public static String getIntRefValue(OsmPrimitive osmPrimitive) { @@ -513,4 +560,5 @@ * Check if OSM primitive has a tag 'whitewater:section_grade'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'whitewater:section_grade' */ public static boolean hasWhitewaterSectionGradeTag(OsmPrimitive osmPrimitive) { @@ -521,4 +569,5 @@ * Gets the value of tag 'whitewater:section_grade'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'whitewater:section_grade' */ public static String getWhitewaterSectionGradeValue( @@ -531,4 +580,5 @@ * Check if OSM primitive has a tag 'denomination'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'denomination' */ public static boolean hasDenominationTag(OsmPrimitive osmPrimitive) { @@ -539,4 +589,5 @@ * Gets the value of tag 'denomination'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'denomination' */ public static String getDenominationValue(OsmPrimitive osmPrimitive) { @@ -547,4 +598,5 @@ * Check if OSM primitive has a tag 'addr:postcode'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:postcode' */ public static boolean hasAddrPostcodeTag(OsmPrimitive osmPrimitive) { @@ -555,4 +607,5 @@ * Gets the value of tag 'addr:postcode'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:postcode' */ public static String getAddrPostcodeValue(OsmPrimitive osmPrimitive) { @@ -563,4 +616,5 @@ * Check if OSM primitive has a tag 'wires'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'wires' */ public static boolean hasWiresTag(OsmPrimitive osmPrimitive) { @@ -571,4 +625,5 @@ * Gets the value of tag 'wires'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'wires' */ public static String getWiresValue(OsmPrimitive osmPrimitive) { @@ -579,4 +634,5 @@ * Check if OSM primitive has a tag 'loc_ref'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'loc_ref' */ public static boolean hasLocRefTag(OsmPrimitive osmPrimitive) { @@ -587,4 +643,5 @@ * Gets the value of tag 'loc_ref'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'loc_ref' */ public static String getLocRefValue(OsmPrimitive osmPrimitive) { @@ -595,4 +652,5 @@ * Check if OSM primitive has a tag 'width'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'width' */ public static boolean hasWidthTag(OsmPrimitive osmPrimitive) { @@ -603,4 +661,5 @@ * Gets the value of tag 'width'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'width' */ public static String getWidthValue(OsmPrimitive osmPrimitive) { @@ -611,4 +670,5 @@ * Check if OSM primitive has a tag 'tourism'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'tourism' */ public static boolean hasTourismTag(OsmPrimitive osmPrimitive) { @@ -619,4 +679,5 @@ * Gets the value of tag 'tourism'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'tourism' */ public static String getTourismValue(OsmPrimitive osmPrimitive) { @@ -627,4 +688,5 @@ * Check if OSM primitive has a tag 'leisure'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'leisure' */ public static boolean hasLeisureTag(OsmPrimitive osmPrimitive) { @@ -635,4 +697,5 @@ * Gets the value of tag 'leisure'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'leisure' */ public static String getLeisureValue(OsmPrimitive osmPrimitive) { @@ -643,4 +706,5 @@ * Check if OSM primitive has a tag 'electrified'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'electrified' */ public static boolean hasElectrifiedTag(OsmPrimitive osmPrimitive) { @@ -652,4 +716,5 @@ * * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'electrified' */ public static String getElectrifiedValue(OsmPrimitive osmPrimitive) { @@ -660,4 +725,5 @@ * Check if OSM primitive has a tag 'junction'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'junction' */ public static boolean hasJunctionTag(OsmPrimitive osmPrimitive) { @@ -668,4 +734,5 @@ * Gets the value of tag 'junction'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'junction' */ public static String getJunctionValue(OsmPrimitive osmPrimitive) { @@ -676,4 +743,5 @@ * Check if OSM primitive has a tag 'railway'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'railway' */ public static boolean hasRailwayTag(OsmPrimitive osmPrimitive) { @@ -684,4 +752,5 @@ * Gets the value of tag 'railway'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'railway' */ public static String getRailwayValue(OsmPrimitive osmPrimitive) { @@ -692,4 +761,5 @@ * Check if OSM primitive has a tag 'voltage'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'voltage' */ public static boolean hasVoltageTag(OsmPrimitive osmPrimitive) { @@ -700,4 +770,5 @@ * Gets the value of tag 'voltage'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'voltage */ public static String getVoltageValue(OsmPrimitive osmPrimitive) { @@ -708,4 +779,5 @@ * Check if OSM primitive has a tag 'bridge'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'bridge' */ public static boolean hasBridgeTag(OsmPrimitive osmPrimitive) { @@ -716,4 +788,5 @@ * Gets the value of tag 'bridge'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'bridge' */ public static String getBridgeValue(OsmPrimitive osmPrimitive) { @@ -724,4 +797,5 @@ * Check if OSM primitive has a tag 'motor_vehicle'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'motor_vehicle' */ public static boolean hasMotorVehicleTag(OsmPrimitive osmPrimitive) { @@ -732,4 +806,5 @@ * Gets the value of tag 'motor_vehicle'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'motor_vehicle' */ public static String getMotorVehicleValue(OsmPrimitive osmPrimitive) { @@ -740,4 +815,5 @@ * Check if OSM primitive has a tag 'comment'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'comment' */ public static boolean hasCommentTag(OsmPrimitive osmPrimitive) { @@ -748,4 +824,5 @@ * Gets the value of tag 'comment'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'comment' */ public static String getCommentValue(OsmPrimitive osmPrimitive) { @@ -756,4 +833,5 @@ * Check if OSM primitive has a tag 'maxspeed'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'maxspeed' */ public static boolean hasMaxspeedTag(OsmPrimitive osmPrimitive) { @@ -764,4 +842,5 @@ * Gets the value of tag 'maxspeed'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'maxspeed' */ public static String getMaxspeedValue(OsmPrimitive osmPrimitive) { @@ -772,4 +851,5 @@ * Check if OSM primitive has a tag 'natural'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'natural' */ public static boolean hasNaturalTag(OsmPrimitive osmPrimitive) { @@ -780,4 +860,5 @@ * Gets the value of tag 'natural'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'natural' */ public static String getNaturalValue(OsmPrimitive osmPrimitive) { @@ -788,4 +869,5 @@ * Check if OSM primitive has a tag 'sac_scale'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'sac_scale' */ public static boolean hasSacScaleTag(OsmPrimitive osmPrimitive) { @@ -796,4 +878,5 @@ * Gets the value of tag 'sac_scale'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'sac_scale' */ public static String getSacScaleValue(OsmPrimitive osmPrimitive) { @@ -804,4 +887,5 @@ * Check if OSM primitive has a tag 'tunnel'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'tunnel' */ public static boolean hasTunnelTag(OsmPrimitive osmPrimitive) { @@ -812,4 +896,5 @@ * Gets the value of tag 'tunnel'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'tunnel' */ public static String getTunnelValue(OsmPrimitive osmPrimitive) { @@ -820,4 +905,5 @@ * Check if OSM primitive has a tag 'waterway'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'waterway' */ public static boolean hasWaterwayTag(OsmPrimitive osmPrimitive) { @@ -828,4 +914,5 @@ * Gets the value of tag 'waterway'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'waterway' */ public static String getWaterwayValue(OsmPrimitive osmPrimitive) { @@ -836,4 +923,5 @@ * Check if OSM primitive has a tag 'trail_visibility'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'trail_visibility' */ public static boolean hasTrailVisibilityTag(OsmPrimitive osmPrimitive) { @@ -844,4 +932,5 @@ * Gets the value of tag 'trail_visibility'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'trail_visibility' */ public static String getTrailVisibilityValue(OsmPrimitive osmPrimitive) { @@ -852,4 +941,5 @@ * Check if OSM primitive has a tag 'highway'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'highway' */ public static boolean hasHighwayTag(OsmPrimitive osmPrimitive) { @@ -860,4 +950,5 @@ * Gets the value of tag 'highway'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'highway' */ public static String getHighwayValue(OsmPrimitive osmPrimitive) { @@ -868,4 +959,5 @@ * Check if OSM primitive has a tag 'vehicle'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'vehicle' */ public static boolean hasVehicleTag(OsmPrimitive osmPrimitive) { @@ -876,4 +968,5 @@ * Gets the value of tag 'vehicle'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'vehicle' */ public static String getVehicleValue(OsmPrimitive osmPrimitive) { @@ -884,4 +977,5 @@ * Check if OSM primitive has a tag 'horse'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'horse' */ public static boolean hasHorseTag(OsmPrimitive osmPrimitive) { @@ -892,4 +986,5 @@ * Gets the value of tag 'horse'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'horse' */ public static String getHorseValue(OsmPrimitive osmPrimitive) { @@ -900,4 +995,5 @@ * Check if OSM primitive has a tag 'goods'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'goods' */ public static boolean hasGoodsTag(OsmPrimitive osmPrimitive) { @@ -908,4 +1004,5 @@ * Gets the value of tag 'goods'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'goods' */ public static String getGoodsValue(OsmPrimitive osmPrimitive) { @@ -916,4 +1013,5 @@ * Check if OSM primitive has a tag 'frequency'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'frequency' */ public static boolean hasFrequencyTag(OsmPrimitive osmPrimitive) { @@ -924,4 +1022,5 @@ * Gets the value of tag 'frequency'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'frequency' */ public static String getFrequencyValue(OsmPrimitive osmPrimitive) { @@ -932,4 +1031,5 @@ * Check if OSM primitive has a tag 'man_made'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'man_made' */ public static boolean hasManMadeTag(OsmPrimitive osmPrimitive) { @@ -940,4 +1040,5 @@ * Gets the value of tag 'man_made'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'man_made' */ public static String getManMadeValue(OsmPrimitive osmPrimitive) { @@ -948,4 +1049,5 @@ * Check if OSM primitive has a tag 'addr:housenumber'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:housenumber' */ public static boolean hasAddrHousenumberTag(OsmPrimitive osmPrimitive) { @@ -956,4 +1058,5 @@ * Gets the value of tag 'addr:housenumber'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:housenumber' */ public static String getAddrHousenumberValue(OsmPrimitive osmPrimitive) { @@ -964,4 +1067,5 @@ * Check if OSM primitive has a tag 'addr:housename'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:housename' */ public static boolean hasAddrHousenameTag(OsmPrimitive osmPrimitive) { @@ -972,4 +1076,5 @@ * Gets the value of tag 'addr:housename'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:housename' */ public static String getAddrHousenameValue(OsmPrimitive osmPrimitive) { @@ -980,4 +1085,5 @@ * Check if OSM primitive has a tag 'area'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'area' */ public static boolean hasAreaTag(OsmPrimitive osmPrimitive) { @@ -988,4 +1094,5 @@ * Gets the value of tag 'area'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'area' */ public static String getAreaValue(OsmPrimitive osmPrimitive) { @@ -996,4 +1103,5 @@ * Check if OSM primitive has a tag 'building:levels'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'building:levels' */ public static boolean hasBuildingLevelsTag(OsmPrimitive osmPrimitive) { @@ -1004,4 +1112,5 @@ * Gets the value of tag 'building:levels'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'building:levels' */ public static String getBuildingLevelsValue(OsmPrimitive osmPrimitive) { @@ -1012,4 +1121,5 @@ * Check if OSM primitive has a tag 'wheelchair'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'wheelchair' */ public static boolean hasWheelchairTag(OsmPrimitive osmPrimitive) { @@ -1020,4 +1130,5 @@ * Gets the value of tag 'wheelchair'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'wheelchair' */ public static String getWheelchairValue(OsmPrimitive osmPrimitive) { @@ -1028,4 +1139,5 @@ * Check if OSM primitive has a tag 'name'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'name' */ public static boolean hasNameTag(OsmPrimitive osmPrimitive) { @@ -1036,4 +1148,5 @@ * Gets the value of tag 'name'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'name' */ public static String getNameValue(OsmPrimitive osmPrimitive) { @@ -1044,4 +1157,5 @@ * Check if OSM primitive has a tag 'oneway'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'oneway' */ public static boolean hasOnewayTag(OsmPrimitive osmPrimitive) { @@ -1052,4 +1166,5 @@ * Gets the value of tag 'oneway'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'oneway' */ public static String getOnewayValue(OsmPrimitive osmPrimitive) { @@ -1060,4 +1175,5 @@ * Check if OSM primitive has a tag 'FIXME'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'FIXME' */ public static boolean hasFIXMETag(OsmPrimitive osmPrimitive) { @@ -1068,4 +1184,5 @@ * Gets the value of tag 'FIXME'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'FIXME' */ public static String getFIXMEValue(OsmPrimitive osmPrimitive) { @@ -1076,4 +1193,5 @@ * Check if OSM primitive has a tag 'capacity'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'capacity' */ public static boolean hasCapacityTag(OsmPrimitive osmPrimitive) { @@ -1084,4 +1202,5 @@ * Gets the value of tag 'capacity'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'capacity' */ public static String getCapacityValue(OsmPrimitive osmPrimitive) { @@ -1092,4 +1211,5 @@ * Check if OSM primitive has a tag 'motorcycle'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'motorcycle' */ public static boolean hasMotorcycleTag(OsmPrimitive osmPrimitive) { @@ -1100,4 +1220,5 @@ * Gets the value of tag 'motorcycle'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'motorcycle' */ public static String getMotorcycleValue(OsmPrimitive osmPrimitive) { @@ -1108,4 +1229,5 @@ * Check if OSM primitive has a tag 'hgv'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'hgv' */ public static boolean hasHgvTag(OsmPrimitive osmPrimitive) { @@ -1116,4 +1238,5 @@ * Gets the value of tag 'hgv'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'hgv' */ public static String getHgvValue(OsmPrimitive osmPrimitive) { @@ -1124,4 +1247,5 @@ * Check if OSM primitive has a tag 'construction'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'construction' */ public static boolean hasConstructionTag(OsmPrimitive osmPrimitive) { @@ -1132,4 +1256,5 @@ * Gets the value of tag 'construction'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'construction' */ public static String getConstructionValue(OsmPrimitive osmPrimitive) { @@ -1140,4 +1265,5 @@ * Check if OSM primitive has a tag 'addr:state'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:state' */ public static boolean hasAddrStateTag(OsmPrimitive osmPrimitive) { @@ -1148,4 +1274,5 @@ * Gets the value of tag 'addr:state'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:state' */ public static String getAddrStateValue(OsmPrimitive osmPrimitive) { @@ -1156,4 +1283,5 @@ * Check if OSM primitive has a tag 'lanes'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'lanes' */ public static boolean hasLanesTag(OsmPrimitive osmPrimitive) { @@ -1164,4 +1292,5 @@ * Gets the value of tag 'lanes'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'lanes' */ public static String getLanesValue(OsmPrimitive osmPrimitive) { @@ -1172,4 +1301,5 @@ * Check if OSM primitive has a tag 'note'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'note' */ public static boolean hasNoteTag(OsmPrimitive osmPrimitive) { @@ -1180,4 +1310,5 @@ * Gets the value of tag 'note'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'note' */ public static String getNoteValue(OsmPrimitive osmPrimitive) { @@ -1188,4 +1319,5 @@ * Check if OSM primitive has a tag 'lit'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'lit' */ public static boolean hasLitTag(OsmPrimitive osmPrimitive) { @@ -1196,4 +1328,5 @@ * Gets the value of tag 'lit'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'lit' */ public static String getLitValue(OsmPrimitive osmPrimitive) { @@ -1204,4 +1337,5 @@ * Check if OSM primitive has a tag 'building'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'building' */ public static boolean hasBuildingTag(OsmPrimitive osmPrimitive) { @@ -1212,4 +1346,5 @@ * Gets the value of tag 'building'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'building' */ public static String getBuildingValue(OsmPrimitive osmPrimitive) { @@ -1220,4 +1355,5 @@ * Check if OSM primitive has a tag 'segregated'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'segregated' */ public static boolean hasSegregatedTag(OsmPrimitive osmPrimitive) { @@ -1228,4 +1364,5 @@ * Gets the value of tag 'segregated'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'segregated' */ public static String getSegregatedValue(OsmPrimitive osmPrimitive) { @@ -1236,4 +1373,5 @@ * Check if OSM primitive has a tag 'addr:inclusion'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:inclusion' */ public static boolean hasAddrInclusionTag(OsmPrimitive osmPrimitive) { @@ -1244,4 +1382,5 @@ * Gets the value of tag 'addr:inclusion'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:inclusion' */ public static String getAddrInclusionValue(OsmPrimitive osmPrimitive) { @@ -1252,4 +1391,5 @@ * Check if OSM primitive has a tag 'layer'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'layer' */ public static boolean hasLayerTag(OsmPrimitive osmPrimitive) { @@ -1260,4 +1400,5 @@ * Gets the value of tag 'layer'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'layer' */ public static String getLayerValue(OsmPrimitive osmPrimitive) { @@ -1268,4 +1409,5 @@ * Check if OSM primitive has a tag 'sport'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'sport' */ public static boolean hasSportTag(OsmPrimitive osmPrimitive) { @@ -1276,4 +1418,5 @@ * Gets the value of tag 'sport'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'sport' */ public static String getSportValue(OsmPrimitive osmPrimitive) { @@ -1284,4 +1427,5 @@ * Check if OSM primitive has a tag 'addr:interpolation'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:interpolation' */ public static boolean hasAddrInterpolationTag(OsmPrimitive osmPrimitive) { @@ -1292,4 +1436,5 @@ * Gets the value of tag 'addr:interpolation'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:interpolation' */ public static String getAddrInterpolationValue(OsmPrimitive osmPrimitive) { @@ -1300,4 +1445,5 @@ * Check if OSM primitive has a tag 'cutting'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'cutting' */ public static boolean hasCuttingTag(OsmPrimitive osmPrimitive) { @@ -1308,4 +1454,5 @@ * Gets the value of tag 'cutting'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'cutting' */ public static String getCuttingValue(OsmPrimitive osmPrimitive) { @@ -1316,4 +1463,5 @@ * Check if OSM primitive has a tag 'amenity'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'amenity' */ public static boolean hasAmenityTag(OsmPrimitive osmPrimitive) { @@ -1324,4 +1472,5 @@ * Gets the value of tag 'amenity'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'amenity' */ public static String getAmenityValue(OsmPrimitive osmPrimitive) { @@ -1332,4 +1481,5 @@ * Check if OSM primitive has a tag 'access'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'access' */ public static boolean hasAccessTag(OsmPrimitive osmPrimitive) { @@ -1340,4 +1490,5 @@ * Gets the value of tag 'access'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'access' */ public static String getAccessValue(OsmPrimitive osmPrimitive) { @@ -1348,4 +1499,5 @@ * Check if OSM primitive has a tag 'agricultural'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'agricultural' */ public static boolean hasAgriculturalTag(OsmPrimitive osmPrimitive) { @@ -1357,4 +1509,5 @@ * Gets the value of tag 'agricultural'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'agricultural' */ public static String getAgriculturalValue(OsmPrimitive osmPrimitive) { @@ -1365,4 +1518,5 @@ * Check if OSM primitive has a tag 'capacity:disabled'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'capacity:disabled' */ public static boolean hasCapacityDisabledTag(OsmPrimitive osmPrimitive) { @@ -1374,4 +1528,5 @@ * Gets the value of tag 'capacity:disabled'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'capacity:disabled' */ public static String getCapacityDisabledValue(OsmPrimitive osmPrimitive) { @@ -1382,4 +1537,5 @@ * Check if OSM primitive has a tag 'operator'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'operator' */ public static boolean hasOperatorTag(OsmPrimitive osmPrimitive) { @@ -1390,4 +1546,5 @@ * Gets the value of tag 'operator'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'operator' */ public static String getOperatorValue(OsmPrimitive osmPrimitive) { @@ -1398,4 +1555,5 @@ * Check if OSM primitive has a tag 'ref'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'ref' */ public static boolean hasRefTag(OsmPrimitive osmPrimitive) { @@ -1406,4 +1564,5 @@ * Gets the value of tag 'ref'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'ref' */ public static String getRefValue(OsmPrimitive osmPrimitive) { @@ -1414,4 +1573,5 @@ * Check if OSM primitive has a tag 'noexit'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'noexit' */ public static boolean hasNoexitTag(OsmPrimitive osmPrimitive) { @@ -1422,4 +1582,5 @@ * Gets the value of tag 'noexit'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'noexit' */ public static String getNoexitValue(OsmPrimitive osmPrimitive) { @@ -1430,4 +1591,5 @@ * Check if OSM primitive has a tag 'admin_level'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'admin_level' */ public static boolean hasAdminLevelTag(OsmPrimitive osmPrimitive) { @@ -1438,4 +1600,5 @@ * Gets the value of tag 'admin_level'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'admin_level' */ public static String getAdminLevelValue(OsmPrimitive osmPrimitive) { @@ -1446,4 +1609,5 @@ * Check if OSM primitive has a tag 'source'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'source' */ public static boolean hasSourceTag(OsmPrimitive osmPrimitive) { @@ -1454,4 +1618,5 @@ * Gets the value of tag 'source'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'source' */ public static String getSourceValue(OsmPrimitive osmPrimitive) { @@ -1462,4 +1627,5 @@ * Check if OSM primitive has a tag 'tracktype'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'tracktype' */ public static boolean hasTracktypeTag(OsmPrimitive osmPrimitive) { @@ -1470,4 +1636,5 @@ * Gets the value of tag 'tracktype'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'tracktype' */ public static String getTracktypeValue(OsmPrimitive osmPrimitive) { @@ -1478,4 +1645,5 @@ * Check if OSM primitive has a tag 'addr:country'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'addr:country' */ public static boolean hasAddrCountryTag(OsmPrimitive osmPrimitive) { @@ -1486,4 +1654,5 @@ * Gets the value of tag 'addr:country'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'addr:country' */ public static String getAddrCountryValue(OsmPrimitive osmPrimitive) { @@ -1494,4 +1663,5 @@ * Check if OSM primitive has a tag 'route'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'route' */ public static boolean hasRouteTag(OsmPrimitive osmPrimitive) { @@ -1502,4 +1672,5 @@ * Gets the value of tag 'route'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'route' */ public static String getRouteValue(OsmPrimitive osmPrimitive) { @@ -1510,4 +1681,5 @@ * Check if OSM primitive has a tag 'cables'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'cables' */ public static boolean hasCablesTag(OsmPrimitive osmPrimitive) { @@ -1518,4 +1690,5 @@ * Gets the value of tag 'cables'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'cables' */ public static String getCablesValue(OsmPrimitive osmPrimitive) { @@ -1526,4 +1699,5 @@ * Check if OSM primitive has a tag 'service'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'service' */ public static boolean hasServiceTag(OsmPrimitive osmPrimitive) { @@ -1534,4 +1708,5 @@ * Gets the value of tag 'service'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'service' */ public static String getServiceValue(OsmPrimitive osmPrimitive) { @@ -1542,4 +1717,5 @@ * Check if OSM primitive has a tag 'motorcar'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'motorcar' */ public static boolean hasMotorcarTag(OsmPrimitive osmPrimitive) { @@ -1550,4 +1726,5 @@ * Gets the value of tag 'motorcar'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'motorcar' */ public static String getMotorcarValue(OsmPrimitive osmPrimitive) { @@ -1558,4 +1735,5 @@ * Check if OSM primitive has a tag 'whitewater'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'whitewater' */ public static boolean hasWhitewaterTag(OsmPrimitive osmPrimitive) { @@ -1566,4 +1744,5 @@ * Gets the value of tag 'whitewater'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'whitewater' */ public static String getWhitewaterValue(OsmPrimitive osmPrimitive) { @@ -1574,4 +1753,5 @@ * Check if OSM primitive has a tag 'embankment'. * @param osmPrimitive The OSM entity to check. + * @return {@code true} if OSM primitive has a tag 'embankment' */ public static boolean hasEmbankmentTag(OsmPrimitive osmPrimitive) { @@ -1582,4 +1762,5 @@ * Gets the value of tag 'embankment'. * @param osmPrimitive The OSM entity to check. + * @return the value of tag 'embankment' */ public static String getEmbankmentValue(OsmPrimitive osmPrimitive) { @@ -1617,5 +1798,6 @@ /** * Check if OSM relation is a 'associatedStreet' relation. - * @param osmPrimitive The OSM entity to check. + * @param rel The relation to check. + * @return {@code true} if OSM relation is a 'associatedStreet' relation */ public static boolean isAssociatedStreetRelation(Relation rel) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditDialog.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditDialog.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditDialog.java (revision 34880) @@ -50,4 +50,7 @@ import org.openstreetmap.josm.tools.Logging; +/** + * Address Edit dialog. + */ @SuppressWarnings("serial") public class AddressEditDialog extends JDialog implements ActionListener, ListSelectionListener, IAddressEditContainerListener { @@ -367,6 +370,4 @@ * the jumpToEntry event occurs, that object's appropriate * method is invoked. - * - * @see JumpToEntryEvent */ class JumpToEntryListener implements KeyListener { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditModel.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditModel.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditModel.java (revision 34880) @@ -14,4 +14,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.OSMStreet; +/** + * Address Edit model. + */ public class AddressEditModel { private List streets; Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditSelectionEvent.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditSelectionEvent.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditSelectionEvent.java (revision 34880) @@ -12,8 +12,9 @@ import org.openstreetmap.josm.plugins.fixAddresses.OSMStreet; +/** + * Address Edit selection event + */ public class AddressEditSelectionEvent extends ActionEvent { - /** - * - */ + private static final long serialVersionUID = -93034483427803409L; private JTable streetTable; @@ -30,5 +31,5 @@ * @param selStreet The street table component. * @param unresolvedAddresses The unresolved addresses table component. - * @param incomplete The incomplete addresses table component. + * @param incompleteAddresses The incomplete addresses table component. * @param container The address container instance holding the entities for streets and addresses. */ Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditTableModel.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditTableModel.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/AddressEditTableModel.java (revision 34880) @@ -17,4 +17,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.IOSMEntity; +/** + * Address edit table model. + */ @SuppressWarnings("serial") public abstract class AddressEditTableModel extends DefaultTableModel implements @@ -36,11 +39,5 @@ fireTableDataChanged(); // update model } else { - SwingUtilities.invokeLater(new Runnable() { - - @Override - public void run() { - fireTableDataChanged(); // update model - } - }); + SwingUtilities.invokeLater(() -> fireTableDataChanged()); } } @@ -91,6 +88,4 @@ * the column event occurs, that object's appropriate * method is invoked. - * - * @see ColumnEvent */ class ColumnListener extends MouseAdapter { @@ -139,4 +134,5 @@ /** * Internal base class to sort items by different columns. + * @param item type */ protected abstract static class ColumnSorter implements Comparator { @@ -148,4 +144,5 @@ * * @param column the column to sort by + * @param ascending if sort mode is ascending or not */ public ColumnSorter(int column, boolean ascending) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/BBoxMapRectangle.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/BBoxMapRectangle.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/BBoxMapRectangle.java (revision 34880) @@ -9,4 +9,7 @@ import org.openstreetmap.josm.data.osm.BBox; +/** + * A {@link MapRectangleImpl} constructed from a {@link BBox}. + */ public class BBoxMapRectangle extends MapRectangleImpl { private BBox bbox; Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesDialog.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesDialog.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesDialog.java (revision 34880) @@ -32,4 +32,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.gui.actions.AddressActions; +/** + * Incomplete addresses dialog. + */ @SuppressWarnings("serial") public class IncompleteAddressesDialog extends ToggleDialog implements DataSetListener, ListSelectionListener, IAddressEditContainerListener { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesTableModel.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesTableModel.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/IncompleteAddressesTableModel.java (revision 34880) @@ -11,8 +11,9 @@ import org.openstreetmap.josm.plugins.fixAddresses.OSMAddress; +/** + * Incomplete addresses table model. + */ public class IncompleteAddressesTableModel extends AddressEditTableModel { - /** - * - */ + private static final long serialVersionUID = -5951629033395186324L; Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/StreetTableModel.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/StreetTableModel.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/StreetTableModel.java (revision 34880) @@ -10,4 +10,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.OSMStreet; +/** + * Street table model. + */ @SuppressWarnings("serial") public class StreetTableModel extends AddressEditTableModel { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AbstractAddressEditAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AbstractAddressEditAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AbstractAddressEditAction.java (revision 34880) @@ -117,5 +117,5 @@ /** * Updates 'enabled' state depending on the current selection. - * @param container The selection event. + * @param event The selection event. */ protected abstract void updateEnabledState(AddressEditSelectionEvent event); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AddressActions.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AddressActions.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/AddressActions.java (revision 34880) @@ -2,4 +2,7 @@ package org.openstreetmap.josm.plugins.fixAddresses.gui.actions; +/** + * Global action objects + */ public final class AddressActions { @@ -8,5 +11,4 @@ } - /* Global action objects */ public static SelectAddressesInMapAction getSelectAction() { return new SelectAddressesInMapAction(); Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ApplyAllGuessesAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ApplyAllGuessesAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ApplyAllGuessesAction.java (revision 34880) @@ -29,4 +29,5 @@ /** * Instantiates a new "apply all guesses" action. + * @param tag tag to analyze */ public ApplyAllGuessesAction(String tag) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertAllToRelationAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertAllToRelationAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertAllToRelationAction.java (revision 34880) @@ -8,4 +8,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.gui.AddressEditSelectionEvent; +/** + * Create relation between street and related addresses for ALL streets in the current layer. + */ @SuppressWarnings("serial") public class ConvertAllToRelationAction extends ConvertToRelationAction { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertToRelationAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertToRelationAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/ConvertToRelationAction.java (revision 34880) @@ -14,4 +14,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.gui.AddressEditSelectionEvent; +/** + * Create relation between street and related addresses. + */ @SuppressWarnings("serial") public class ConvertToRelationAction extends AbstractAddressEditAction { @@ -29,4 +32,5 @@ * @param iconName the icon name * @param tooltip the tool tip to show on hover + * @param toolbar identifier for the toolbar preferences */ public ConvertToRelationAction(String name, String iconName, String tooltip, String toolbar) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/GuessAddressDataAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/GuessAddressDataAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/GuessAddressDataAction.java (revision 34880) @@ -58,4 +58,5 @@ /** * Internal method to start several threads guessing tag values for the given list of addresses. + * @param nodes list of OSM addresses */ private void internalGuessAddresses(List nodes) { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/RemoveAddressTagsAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/RemoveAddressTagsAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/RemoveAddressTagsAction.java (revision 34880) @@ -8,4 +8,7 @@ import org.openstreetmap.josm.plugins.fixAddresses.gui.AddressEditSelectionEvent; +/** + * Removes address related tags from the object. + */ @SuppressWarnings("serial") public class RemoveAddressTagsAction extends AbstractAddressEditAction { Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectAddressesInMapAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectAddressesInMapAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectAddressesInMapAction.java (revision 34880) @@ -14,7 +14,7 @@ /** + * Marks selected addresses in the map. * * @author Oliver Wieland <oliver.wieland@online.de> - * */ @SuppressWarnings("serial") Index: /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectIncompleteAddressesAction.java =================================================================== --- /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectIncompleteAddressesAction.java (revision 34879) +++ /applications/editors/josm/plugins/FixAddresses/src/org/openstreetmap/josm/plugins/fixAddresses/gui/actions/SelectIncompleteAddressesAction.java (revision 34880) @@ -13,7 +13,9 @@ import org.openstreetmap.josm.plugins.fixAddresses.OSMAddress; +/** + * Selects all addresses with incomplete data. + */ @SuppressWarnings("serial") public class SelectIncompleteAddressesAction extends JosmAction { - private AddressEditContainer addressEditContainer;