Index: applications/editors/josm/plugins/wikipedia/.settings/org.eclipse.jdt.core.prefs =================================================================== --- applications/editors/josm/plugins/wikipedia/.settings/org.eclipse.jdt.core.prefs (revision 34078) +++ applications/editors/josm/plugins/wikipedia/.settings/org.eclipse.jdt.core.prefs (revision 34079) @@ -17,4 +17,5 @@ org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.doc.comment.support=enabled org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error @@ -40,4 +41,9 @@ org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore +org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning +org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled +org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=private org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning @@ -46,4 +52,12 @@ org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore +org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore +org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public +org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=return_tag +org.eclipse.jdt.core.compiler.problem.missingJavadocTags=warning +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled +org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=private org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java (revision 34079) @@ -29,5 +29,4 @@ import javax.xml.parsers.ParserConfigurationException; -import org.openstreetmap.josm.Main; import org.openstreetmap.josm.data.coor.LatLon; import org.openstreetmap.josm.data.osm.OsmPrimitive; @@ -222,4 +221,6 @@ /** * Returns a map mapping wikipedia articles to wikidata ids. + * @param articles wikipedia article names + * @return article / wikidata id map */ public Map getWikidataForArticles(Collection articles) { @@ -252,4 +253,6 @@ * Get Wikidata IDs. For any unknown IDs, resolve them (normalize and get redirects), * and try getting Wikidata IDs again + * @param articles wikipedia article names + * @return article / wikidata id map */ private Map resolveWikidataItems(Collection articles) { @@ -323,4 +326,6 @@ * Given a list of wikipedia titles, returns a map of corresponding normalized title names, * or if the title is a redirect page, the result is the redirect target. + * @param articles wikipedia articles + * @return article / wikidata id map */ private Map resolveRedirectsForArticles(Collection articles) { Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/FetchWikidataAction.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/FetchWikidataAction.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/FetchWikidataAction.java (revision 34079) @@ -15,5 +15,4 @@ import javax.swing.JOptionPane; -import org.openstreetmap.josm.Main; import org.openstreetmap.josm.actions.JosmAction; import org.openstreetmap.josm.command.ChangePropertyCommand; Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/WikipediaCopyTemplate.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/WikipediaCopyTemplate.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/actions/WikipediaCopyTemplate.java (revision 34079) @@ -47,5 +47,5 @@ /** * Class to hold copy templates for serialization using {@link Preferences}. - * Public visibility is needed for reflection used in {@link Preferences#getListOfStructs}. + * Public visibility is needed for reflection used in {@link Preferences#getListOfMaps}. */ @SuppressWarnings("WeakerAccess") Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikidataTagCellRenderer.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikidataTagCellRenderer.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikidataTagCellRenderer.java (revision 34079) @@ -19,5 +19,4 @@ import javax.swing.table.DefaultTableCellRenderer; -import org.openstreetmap.josm.Main; import org.openstreetmap.josm.gui.util.GuiHelper; import org.openstreetmap.josm.tools.Logging; Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikipediaToggleDialog.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikipediaToggleDialog.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/gui/WikipediaToggleDialog.java (revision 34079) @@ -2,4 +2,5 @@ package org.wikipedia.gui; +import static org.openstreetmap.josm.gui.help.HelpUtil.ht; import static org.openstreetmap.josm.tools.I18n.tr; @@ -367,4 +368,9 @@ @Override + public String helpTopic() { + return ht("/Plugin/Wikipedia"); + } + + @Override public void showNotify() { DatasetEventManager.getInstance().addDatasetListener(dataChangedAdapter, FireMode.IN_EDT_CONSOLIDATED); Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/io/SophoxDownloadReader.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/io/SophoxDownloadReader.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/io/SophoxDownloadReader.java (revision 34079) @@ -68,4 +68,7 @@ * @param sophoxServer The Sophox server to use * @param sophoxQuery The Sophox query + * @param asNewLayer if the data should be downloaded into a new layer + * @param downloadReferrers if the referrers of the object should be downloaded as well + * @param downloadFull if the members of a relation should be downloaded as well */ public SophoxDownloadReader(Bounds downloadArea, String sophoxServer, String sophoxQuery, Index: applications/editors/josm/plugins/wikipedia/src/org/wikipedia/tools/Debouncer.java =================================================================== --- applications/editors/josm/plugins/wikipedia/src/org/wikipedia/tools/Debouncer.java (revision 34078) +++ applications/editors/josm/plugins/wikipedia/src/org/wikipedia/tools/Debouncer.java (revision 34079) @@ -18,4 +18,8 @@ * Debounces {@code callable} by {@code delay}, i.e., schedules it to be executed after {@code delay}, * or cancels its execution if the method is called with the same key within the {@code delay} again. + * @param key key + * @param runnable runnable to be scheduled + * @param delay delay value + * @param unit delay time unit */ public void debounce(final Object key, final Runnable runnable, long delay, TimeUnit unit) {