Index: /applications/editors/josm/plugins/pointInfo/.checkstyle =================================================================== --- /applications/editors/josm/plugins/pointInfo/.checkstyle (revision 32844) +++ /applications/editors/josm/plugins/pointInfo/.checkstyle (revision 32844) @@ -0,0 +1,18 @@ + + + + + + + + + + + + + + + + + + Index: /applications/editors/josm/plugins/pointInfo/.classpath =================================================================== --- /applications/editors/josm/plugins/pointInfo/.classpath (revision 32843) +++ /applications/editors/josm/plugins/pointInfo/.classpath (revision 32844) @@ -2,11 +2,6 @@ - - + + + Index: /applications/editors/josm/plugins/pointInfo/.project =================================================================== --- /applications/editors/josm/plugins/pointInfo/.project (revision 32844) +++ /applications/editors/josm/plugins/pointInfo/.project (revision 32844) @@ -0,0 +1,23 @@ + + + JOSM-PointInfo + + + + + + org.eclipse.jdt.core.javabuilder + + + + + net.sf.eclipsecs.core.CheckstyleBuilder + + + + + + org.eclipse.jdt.core.javanature + net.sf.eclipsecs.core.CheckstyleNature + + Index: /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.core.resources.prefs =================================================================== --- /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.core.resources.prefs (revision 32844) +++ /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.core.resources.prefs (revision 32844) @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +encoding/=UTF-8 Index: /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.core.prefs =================================================================== --- /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.core.prefs (revision 32844) +++ /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.core.prefs (revision 32844) @@ -0,0 +1,7 @@ +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled +org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8 +org.eclipse.jdt.core.compiler.compliance=1.8 +org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.source=1.8 Index: /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.ui.prefs =================================================================== --- /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.ui.prefs (revision 32844) +++ /applications/editors/josm/plugins/pointInfo/.settings/org.eclipse.jdt.ui.prefs (revision 32844) @@ -0,0 +1,60 @@ +eclipse.preferences.version=1 +editor_save_participant_org.eclipse.jdt.ui.postsavelistener.cleanup=true +sp_cleanup.add_default_serial_version_id=true +sp_cleanup.add_generated_serial_version_id=false +sp_cleanup.add_missing_annotations=true +sp_cleanup.add_missing_deprecated_annotations=true +sp_cleanup.add_missing_methods=false +sp_cleanup.add_missing_nls_tags=false +sp_cleanup.add_missing_override_annotations=true +sp_cleanup.add_missing_override_annotations_interface_methods=true +sp_cleanup.add_serial_version_id=false +sp_cleanup.always_use_blocks=true +sp_cleanup.always_use_parentheses_in_expressions=false +sp_cleanup.always_use_this_for_non_static_field_access=false +sp_cleanup.always_use_this_for_non_static_method_access=false +sp_cleanup.convert_functional_interfaces=false +sp_cleanup.convert_to_enhanced_for_loop=false +sp_cleanup.correct_indentation=true +sp_cleanup.format_source_code=false +sp_cleanup.format_source_code_changes_only=false +sp_cleanup.insert_inferred_type_arguments=false +sp_cleanup.make_local_variable_final=true +sp_cleanup.make_parameters_final=false +sp_cleanup.make_private_fields_final=true +sp_cleanup.make_type_abstract_if_missing_method=false +sp_cleanup.make_variable_declarations_final=false +sp_cleanup.never_use_blocks=false +sp_cleanup.never_use_parentheses_in_expressions=true +sp_cleanup.on_save_use_additional_actions=true +sp_cleanup.organize_imports=true +sp_cleanup.qualify_static_field_accesses_with_declaring_class=false +sp_cleanup.qualify_static_member_accesses_through_instances_with_declaring_class=true +sp_cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=true +sp_cleanup.qualify_static_member_accesses_with_declaring_class=false +sp_cleanup.qualify_static_method_accesses_with_declaring_class=false +sp_cleanup.remove_private_constructors=true +sp_cleanup.remove_redundant_type_arguments=true +sp_cleanup.remove_trailing_whitespaces=true +sp_cleanup.remove_trailing_whitespaces_all=true +sp_cleanup.remove_trailing_whitespaces_ignore_empty=false +sp_cleanup.remove_unnecessary_casts=true +sp_cleanup.remove_unnecessary_nls_tags=false +sp_cleanup.remove_unused_imports=true +sp_cleanup.remove_unused_local_variables=false +sp_cleanup.remove_unused_private_fields=true +sp_cleanup.remove_unused_private_members=false +sp_cleanup.remove_unused_private_methods=true +sp_cleanup.remove_unused_private_types=true +sp_cleanup.sort_members=false +sp_cleanup.sort_members_all=false +sp_cleanup.use_anonymous_class_creation=false +sp_cleanup.use_blocks=false +sp_cleanup.use_blocks_only_for_return_and_throw=false +sp_cleanup.use_lambda=true +sp_cleanup.use_parentheses_in_expressions=false +sp_cleanup.use_this_for_non_static_field_access=false +sp_cleanup.use_this_for_non_static_field_access_only_if_necessary=true +sp_cleanup.use_this_for_non_static_method_access=false +sp_cleanup.use_this_for_non_static_method_access_only_if_necessary=true +sp_cleanup.use_type_arguments=false Index: /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoAction.java =================================================================== --- /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoAction.java (revision 32843) +++ /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoAction.java (revision 32844) @@ -1,23 +1,7 @@ -/** - * PointInfo - plugin for JOSM - * Marian Kyral - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ +// License: GPL. For details, see LICENSE file. package org.openstreetmap.josm.plugins.pointinfo; import static org.openstreetmap.josm.tools.I18n.tr; + import java.awt.Cursor; import java.awt.Point; @@ -27,13 +11,9 @@ import java.awt.event.MouseEvent; import java.awt.event.MouseListener; -// import java.awt.event.KeyListener; -import java.util.ArrayList; -import java.util.Collection; -import java.util.LinkedList; -import javax.swing.SwingConstants; + +import javax.swing.ImageIcon; import javax.swing.JEditorPane; import javax.swing.JOptionPane; import javax.swing.JScrollPane; -import javax.swing.ImageIcon; import javax.swing.event.HyperlinkEvent; import javax.swing.event.HyperlinkListener; @@ -41,16 +21,11 @@ import org.openstreetmap.josm.Main; import org.openstreetmap.josm.actions.mapmode.MapMode; -import org.openstreetmap.josm.command.AddCommand; -import org.openstreetmap.josm.command.Command; -import org.openstreetmap.josm.command.SequenceCommand; import org.openstreetmap.josm.data.coor.LatLon; -import org.openstreetmap.josm.data.osm.Node; -import org.openstreetmap.josm.data.osm.Way; +import org.openstreetmap.josm.gui.MapFrame; import org.openstreetmap.josm.gui.PleaseWaitRunnable; import org.openstreetmap.josm.gui.progress.ProgressMonitor; -import org.openstreetmap.josm.gui.MapFrame; import org.openstreetmap.josm.tools.ImageProvider; +import org.openstreetmap.josm.tools.OpenBrowser; import org.openstreetmap.josm.tools.Shortcut; -import org.openstreetmap.josm.tools.OpenBrowser; import org.xml.sax.SAXException; @@ -58,5 +33,4 @@ private static final long serialVersionUID = 1L; - protected boolean cancel; @@ -66,6 +40,8 @@ private String coordinatesText = ""; - public PointInfoAction(MapFrame mapFrame) { - super(tr("Point info"), "info-sml", tr("Point info."), Shortcut.registerShortcut("tools:pointInfo", tr("Tool: {0}", tr("Point info")), KeyEvent.VK_X, Shortcut.CTRL_SHIFT), mapFrame, getCursor()); + PointInfoAction(MapFrame mapFrame) { + super(tr("Point info"), "info-sml", tr("Point info."), + Shortcut.registerShortcut("tools:pointInfo", tr("Tool: {0}", tr("Point info")), KeyEvent.VK_X, Shortcut.CTRL_SHIFT), + mapFrame, getCursor()); } @@ -78,5 +54,4 @@ Main.map.mapView.setCursor(getCursor()); Main.map.mapView.addMouseListener(this); - } @@ -100,5 +75,4 @@ try { PleaseWaitRunnable infoTask = new PleaseWaitRunnable(tr("Connecting server")) { - @Override protected void realRun() throws SAXException { @@ -108,39 +82,38 @@ @Override protected void finish() { - } @Override protected void afterFinish() { - if (htmlText.length() > 0) { - - // Show result - JEditorPane msgLabel = new JEditorPane("text/html", htmlText); - msgLabel.setEditable(false); - msgLabel.setOpaque(false); - msgLabel.addHyperlinkListener(new HyperlinkListener() { - public void hyperlinkUpdate(HyperlinkEvent hle) { - if (HyperlinkEvent.EventType.ACTIVATED.equals(hle.getEventType())) { - if (hle.getURL() == null || hle.getURL().toString().isEmpty()) { - return; + if (htmlText.length() > 0) { + // Show result + JEditorPane msgLabel = new JEditorPane("text/html", htmlText); + msgLabel.setEditable(false); + msgLabel.setOpaque(false); + msgLabel.addHyperlinkListener(new HyperlinkListener() { + @Override + public void hyperlinkUpdate(HyperlinkEvent hle) { + if (HyperlinkEvent.EventType.ACTIVATED.equals(hle.getEventType())) { + if (hle.getURL() == null || hle.getURL().toString().isEmpty()) { + return; + } + System.out.println("URL: "+ hle.getURL()); + if (!hle.getURL().toString().startsWith("http")) { + mRuian.performAction(hle.getURL().toString()); + } else { + String ret = OpenBrowser.displayUrl(hle.getURL().toString()); + if (ret != null) { + PointInfoUtils.showNotification(ret, "error"); + } + } + } } - System.out.println("URL: "+ hle.getURL()); - if (! hle.getURL().toString().startsWith("http")) { - mRuian.performAction(hle.getURL().toString()); - } else { - String ret = OpenBrowser.displayUrl(hle.getURL().toString()); - if (ret != null) { - PointInfoUtils.showNotification(ret, "error"); - } - } - } - } - }); - JScrollPane scrollPane = new JScrollPane(msgLabel); - Object[] objects = {scrollPane}; - final ImageIcon icon = new ImageIcon(getClass().getResource("/images/dialogs/info-sml.png")); - JOptionPane.showMessageDialog( - null, objects, tr("PointInfo") + " " + coordinatesText, JOptionPane.PLAIN_MESSAGE,icon); - } + }); + JScrollPane scrollPane = new JScrollPane(msgLabel); + Object[] objects = {scrollPane}; + final ImageIcon icon = new ImageIcon(getClass().getResource("/images/dialogs/info-sml.png")); + JOptionPane.showMessageDialog( + null, objects, tr("PointInfo") + " " + coordinatesText, JOptionPane.PLAIN_MESSAGE, icon); + } } @@ -150,6 +123,5 @@ } }; - Thread executeInfoThread = new Thread(infoTask); - executeInfoThread.start(); + new Thread(infoTask).start(); } catch (Exception e) { e.printStackTrace(); @@ -161,7 +133,7 @@ progressMonitor.beginTask(null, 3); try { - mRuian.prepareData(pos); - htmlText = mRuian.getHtml(); - coordinatesText = PointInfoUtils.formatCoordinates(pos.lat(), pos.lon()); + mRuian.prepareData(pos); + htmlText = mRuian.getHtml(); + coordinatesText = PointInfoUtils.formatCoordinates(pos.lat(), pos.lon()); } finally { @@ -170,6 +142,6 @@ progressMonitor.invalidate(); if (htmlText.length() == 0) { - PointInfoUtils.showNotification(tr("Data not available.")+ "\n(" + pos.toDisplayString() + ")", "warning"); - return; + PointInfoUtils.showNotification(tr("Data not available.")+ "\n(" + pos.toDisplayString() + ")", "warning"); + return; } } @@ -199,5 +171,5 @@ updateKeyModifiers(e); if (e.getButton() == MouseEvent.BUTTON1) { - infoAsync(e.getPoint()); + infoAsync(e.getPoint()); } } Index: /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoPlugin.java =================================================================== --- /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoPlugin.java (revision 32843) +++ /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoPlugin.java (revision 32844) @@ -1,46 +1,18 @@ -/** - * PointInfo - plugin for JOSM - * Marián Kyral - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - +// License: GPL. For details, see LICENSE file. package org.openstreetmap.josm.plugins.pointinfo; - -import java.util.ArrayList; import org.openstreetmap.josm.Main; import org.openstreetmap.josm.gui.MainMenu; -// import org.openstreetmap.josm.gui.preferences.PreferenceSetting; import org.openstreetmap.josm.plugins.Plugin; import org.openstreetmap.josm.plugins.PluginInformation; - - /** * This is the main class for the PointInfo plugin. - * */ -public class PointInfoPlugin extends Plugin{ +public class PointInfoPlugin extends Plugin { - public PointInfoPlugin(PluginInformation info) { - super(info); - MainMenu.add(Main.main.menu.moreToolsMenu, new PointInfoAction(Main.map)); - -// @Override -// public PreferenceSetting getPreferenceSetting() { -// return new PreferenceEditor(); + public PointInfoPlugin(PluginInformation info) { + super(info); + MainMenu.add(Main.main.menu.moreToolsMenu, new PointInfoAction(Main.map)); } } Index: /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoServer.java =================================================================== --- /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoServer.java (revision 32843) +++ /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoServer.java (revision 32844) @@ -1,21 +1,3 @@ -/** - * PointInfo - plugin for JOSM - * Marian Kyral - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - +// License: GPL. For details, see LICENSE file. package org.openstreetmap.josm.plugins.pointinfo; @@ -23,6 +5,4 @@ import java.io.InputStreamReader; import java.net.URL; -import java.util.ArrayList; -import org.openstreetmap.josm.data.coor.LatLon; public class PointInfoServer { @@ -46,7 +26,7 @@ while ((line = reader.readLine()) != null) { if (sb.length() == 0) - sb.append(line); + sb.append(line); else - sb.append(" "+line); + sb.append(" "+line); } return sb.toString(); Index: /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoUtils.java =================================================================== --- /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoUtils.java (revision 32843) +++ /applications/editors/josm/plugins/pointInfo/src/org/openstreetmap/josm/plugins/pointinfo/PointInfoUtils.java (revision 32844) @@ -1,29 +1,11 @@ -/** - * PointInfo - plugin for JOSM - * Marian Kyral - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - +// License: GPL. For details, see LICENSE file. package org.openstreetmap.josm.plugins.pointinfo; import java.text.DecimalFormat; import java.text.DecimalFormatSymbols; + import javax.swing.JOptionPane; import org.openstreetmap.josm.gui.Notification; - public abstract class PointInfoUtils { @@ -34,18 +16,18 @@ * @param type Type if message (info, warning, error, plain). */ - public static void showNotification (String message, String type) { - Notification note = new Notification(message); + public static void showNotification(String message, String type) { + Notification note = new Notification(message); - if (type.equals("info")) - note.setIcon(JOptionPane.INFORMATION_MESSAGE); - else if (type.equals("warning")) - note.setIcon(JOptionPane.WARNING_MESSAGE); - else if (type.equals("error")) - note.setIcon(JOptionPane.ERROR_MESSAGE); - else - note.setIcon(JOptionPane.PLAIN_MESSAGE); + if (type.equals("info")) + note.setIcon(JOptionPane.INFORMATION_MESSAGE); + else if (type.equals("warning")) + note.setIcon(JOptionPane.WARNING_MESSAGE); + else if (type.equals("error")) + note.setIcon(JOptionPane.ERROR_MESSAGE); + else + note.setIcon(JOptionPane.PLAIN_MESSAGE); - note.setDuration(Notification.TIME_SHORT); - note.show(); + note.setDuration(Notification.TIME_SHORT); + note.show(); } @@ -56,16 +38,15 @@ * @return String coordinatesText */ - public static String formatCoordinates (double lat, double lon) { + public static String formatCoordinates(double lat, double lon) { - String r = ""; - DecimalFormatSymbols symbols = new DecimalFormatSymbols(); - symbols.setDecimalSeparator('.'); - symbols.setGroupingSeparator(' '); - DecimalFormat df = new DecimalFormat("#.00000", symbols); + String r = ""; + DecimalFormatSymbols symbols = new DecimalFormatSymbols(); + symbols.setDecimalSeparator('.'); + symbols.setGroupingSeparator(' '); + DecimalFormat df = new DecimalFormat("#.00000", symbols); - r = "(" + df.format(lat) + ", " + + r = "(" + df.format(lat) + ", " + df.format(lon) + ")"; - return r; + return r; } - }