Index: /applications/editors/josm/plugins/mapdust/.checkstyle =================================================================== --- /applications/editors/josm/plugins/mapdust/.checkstyle (revision 32787) +++ /applications/editors/josm/plugins/mapdust/.checkstyle (revision 32787) @@ -0,0 +1,19 @@ + + + + + + + + + + + + + + + + + + + Index: /applications/editors/josm/plugins/mapdust/.classpath =================================================================== --- /applications/editors/josm/plugins/mapdust/.classpath (revision 32786) +++ /applications/editors/josm/plugins/mapdust/.classpath (revision 32787) @@ -1,9 +1,9 @@ - - - - - - + + + + + + Index: /applications/editors/josm/plugins/mapdust/.project =================================================================== --- /applications/editors/josm/plugins/mapdust/.project (revision 32786) +++ /applications/editors/josm/plugins/mapdust/.project (revision 32787) @@ -1,22 +1,28 @@ - JOSM-mapdust - - - - - - org.eclipse.jdt.core.javabuilder - - - - - org.sonarlint.eclipse.core.sonarlintBuilder - - - - - - org.eclipse.jdt.core.javanature - + JOSM-mapdust + + + + + + org.eclipse.jdt.core.javabuilder + + + + + org.sonarlint.eclipse.core.sonarlintBuilder + + + + + net.sf.eclipsecs.core.CheckstyleBuilder + + + + + + org.eclipse.jdt.core.javanature + net.sf.eclipsecs.core.CheckstyleNature + Index: /applications/editors/josm/plugins/mapdust/LICENSE.txt =================================================================== --- /applications/editors/josm/plugins/mapdust/LICENSE.txt (revision 32786) +++ /applications/editors/josm/plugins/mapdust/LICENSE.txt (revision 32787) Index: /applications/editors/josm/plugins/mapdust/README =================================================================== --- /applications/editors/josm/plugins/mapdust/README (revision 32786) +++ /applications/editors/josm/plugins/mapdust/README (revision 32787) @@ -2,15 +2,15 @@ in order to help to improve the Open Street Map. The MapDust plugin contains the following features: - - viewing the Bug Reports on the current area - - viewing the details of a given Bug report - - creating a new Bug Report - - commenting a new Bug Report - - closing a given Bug Report - - re-opening a given Bug Report - - invalidating a given Bug Report - - working in online and offline mode - + - viewing the Bug Reports on the current area + - viewing the details of a given Bug report + - creating a new Bug Report + - commenting a new Bug Report + - closing a given Bug Report + - re-opening a given Bug Report + - invalidating a given Bug Report + - working in online and offline mode + * This plugin was created by Beata Jancso . * This plugin is licensed under the GNU GPL v3 or later. See GPL-v3,0.txt for more details. - + Index: /applications/editors/josm/plugins/mapdust/build.xml =================================================================== --- /applications/editors/josm/plugins/mapdust/build.xml (revision 32786) +++ /applications/editors/josm/plugins/mapdust/build.xml (revision 32787) @@ -13,5 +13,5 @@ - + Index: /applications/editors/josm/plugins/mapdust/conf/mapdust.properties =================================================================== --- /applications/editors/josm/plugins/mapdust/conf/mapdust.properties (revision 32786) +++ /applications/editors/josm/plugins/mapdust/conf/mapdust.properties (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustLayer.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustLayer.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustLayer.java (revision 32787) @@ -279,5 +279,5 @@ DateFormat df = DateFormat.getDateInstance(DateFormat.DEFAULT, Locale.getDefault()); - String text = "Type: " + bug.getType().getValue() ; + String text = "Type: " + bug.getType().getValue(); text += "
"; text += "Status: " + bug.getStatus().getValue() + "
"; @@ -287,5 +287,5 @@ text += "Created on: " + df.format(bug.getDateCreated()); text += "
"; - text += "Last modified on: "+ df.format(bug.getDateUpdated()) ; + text += "Last modified on: "+ df.format(bug.getDateUpdated()); text += "
"; text += "Comments: " + bug.getNumberOfComments(); Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustPlugin.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustPlugin.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/MapdustPlugin.java (revision 32787) @@ -133,5 +133,5 @@ Main.pref.put("mapdust.showError", true); Main.pref.put("mapdust.version", getPluginInformation().version); - Main.pref.put("mapdust.localVersion",getPluginInformation().localversion); + Main.pref.put("mapdust.localVersion", getPluginInformation().localversion); Main.pref.addPreferenceChangeListener(this); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustActionUploader.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustActionUploader.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustActionUploader.java (revision 32787) @@ -42,5 +42,5 @@ * @version $Revision$ */ -public class MapdustActionUploader { +public final class MapdustActionUploader { /** The MapdustActionUploader instance */ Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustGUI.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustGUI.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/MapdustGUI.java (revision 32787) @@ -248,5 +248,5 @@ } List actionList = actionPanel != null ? - actionPanel.getActionList() : new ArrayList(); + actionPanel.getActionList() : new ArrayList<>(); /* update panels */ Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/WindowClose.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/WindowClose.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/WindowClose.java (revision 32787) @@ -63,5 +63,5 @@ * @param btnPanel The button panel */ - public WindowClose(AbstractDialog dialog, MapdustButtonPanel btnPanel ) { + public WindowClose(AbstractDialog dialog, MapdustButtonPanel btnPanel) { this.dialog = dialog; this.btnPanel = btnPanel; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/adapter/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteCloseBug.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteCloseBug.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteCloseBug.java (revision 32787) @@ -130,5 +130,5 @@ mapdustGUI.enableBtnPanel(true); issueDialog.dispose(); - if (getMapdustGUI().getActionPanel()!= null) { + if (getMapdustGUI().getActionPanel() != null) { notifyObservers(mapdustAction); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteFilterBug.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteFilterBug.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteFilterBug.java (revision 32787) @@ -98,5 +98,5 @@ boolean descr = dialog.isDescrFilterChecked(); MapdustRelevance minValue = dialog.getSelectedMinRelevance(); - MapdustRelevance maxValue= dialog.getSelectedMaxRelevance(); + MapdustRelevance maxValue = dialog.getSelectedMaxRelevance(); /* notifies the observers about the filters */ notifyObservers(new MapdustBugFilter(statuses, types, descr, Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteRefresh.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteRefresh.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteRefresh.java (revision 32787) @@ -58,5 +58,5 @@ /** - * Builds a EexecuteRefresh object + * Builds a EexecuteRefresh object */ public ExecuteRefresh() {} Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteWorkOffline.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteWorkOffline.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/ExecuteWorkOffline.java (revision 32787) @@ -109,5 +109,5 @@ } catch (MapdustActionUploaderException e) { String errorMessage = "There was a Mapdust service"; - errorMessage+=" error."; + errorMessage += " error."; JOptionPane.showMessageDialog(Main.parent, tr(errorMessage), tr("Error"), Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/execute/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/ShowReOpenBugAction.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/ShowReOpenBugAction.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/ShowReOpenBugAction.java (revision 32787) @@ -80,5 +80,6 @@ btn = (JToggleButton) event.getSource(); btn.setSelected(true); - } if (event.getSource() instanceof JMenuItem){ + } + if (event.getSource() instanceof JMenuItem) { getButtonPanel().getBtnReOpenBugReport().setSelected(true); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/action/show/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/AbstractDialog.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/AbstractDialog.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/AbstractDialog.java (revision 32787) @@ -71,4 +71,3 @@ this.firedButton = firedButton; } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/CommentBugDialog.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/CommentBugDialog.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/CommentBugDialog.java (revision 32787) @@ -244,4 +244,3 @@ return btnOk; } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/FilterBugDialog.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/FilterBugDialog.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/FilterBugDialog.java (revision 32787) @@ -66,5 +66,5 @@ */ public class FilterBugDialog extends AbstractDialog { - org.openstreetmap.josm.plugins.mapdust.service.value.BugType ttt=org.openstreetmap.josm.plugins.mapdust.service.value.BugType.WRONG_TURN; + org.openstreetmap.josm.plugins.mapdust.service.value.BugType ttt = org.openstreetmap.josm.plugins.mapdust.service.value.BugType.WRONG_TURN; /** The serial version UID */ @@ -292,5 +292,5 @@ 25)); /* oneway_road type */ - filterTypes[2] = new FilterCheckBox(BugType.MISSING_STREET.getKey(), + filterTypes[2] = new FilterCheckBox(BugType.MISSING_STREET.getKey(), new Rectangle(110, 125, 20, 25), "dialogs/missing_street.png", BugType.MISSING_STREET.getValue(), new Rectangle(130, 125, 150, Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/dialog/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/CommentListModel.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/CommentListModel.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/CommentListModel.java (revision 32787) @@ -90,4 +90,3 @@ @Override public void addListDataListener(ListDataListener l) {} - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/model/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustActionPanel.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustActionPanel.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustActionPanel.java (revision 32787) @@ -84,9 +84,7 @@ * @param mapdustPlugin The MapdustPlugin object */ - private void addComponents(List list, - MapdustPlugin mapdustPlugin) { + private void addComponents(List list, MapdustPlugin mapdustPlugin) { /* create components */ - AbstractAction action = new ExecuteActionList - (mapdustPlugin.getMapdustGUI()); + AbstractAction action = new ExecuteActionList(mapdustPlugin.getMapdustGUI()); JToggleButton btnUpload = ComponentUtil.createJButton("Upload list data", null, null, action); Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustBugListPanel.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustBugListPanel.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustBugListPanel.java (revision 32787) @@ -163,5 +163,5 @@ String text = " No bugs in the current view for the selected"; text += " filters!"; - JList textJList = new JList<>(new String[] { text }); + JList textJList = new JList<>(new String[] {text}); textJList.setBorder(new LineBorder(Color.black, 1, false)); textJList.setCellRenderer(new BugListCellRenderer()); @@ -192,5 +192,5 @@ String text = " No bugs in the current view for the selected"; text += " filters!"; - JList textJList = new JList<>(new String[] { text }); + JList textJList = new JList<>(new String[] {text}); textJList.setBorder(new LineBorder(Color.black, 1, false)); textJList.setCellRenderer(new BugListCellRenderer()); Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustHelpPanel.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustHelpPanel.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/MapdustHelpPanel.java (revision 32787) @@ -100,13 +100,13 @@ private String buildText() { Integer version; - try{ + try { version = Integer.decode(Main.pref.get("mapdust.version")); - } catch (NumberFormatException e){ + } catch (NumberFormatException e) { version = null; } Integer localVersion; - try{ - localVersion= Integer.decode(Main.pref.get("mapdust.localVersion")); + try { + localVersion = Integer.decode(Main.pref.get("mapdust.localVersion")); } catch (NumberFormatException e) { localVersion = null; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/panel/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/BugListCellRenderer.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/BugListCellRenderer.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/BugListCellRenderer.java (revision 32787) @@ -63,6 +63,6 @@ public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean hasFocus) { - JLabel label =(JLabel) super.getListCellRendererComponent(list, value, - index,isSelected, hasFocus); + JLabel label = (JLabel) super.getListCellRendererComponent(list, value, + index, isSelected, hasFocus); if (value instanceof MapdustBug) { /* show the MapdustBug in the list */ @@ -78,5 +78,5 @@ text += mapdustBug.getType().getValue(); if (mapdustBug.getAddress() != null) { - String addressStr=mapdustBug.getAddress().toString(); + String addressStr = mapdustBug.getAddress().toString(); if (!addressStr.trim().isEmpty()) { text += " (" + mapdustBug.getAddress().toString() + " )"; @@ -85,5 +85,5 @@ DateFormat df = DateFormat.getDateInstance(DateFormat.DEFAULT, Locale.getDefault()); - text +=" last modified on "; + text += " last modified on "; text += df.format(mapdustBug.getDateUpdated()); label.setText(text); @@ -91,7 +91,7 @@ label.setSize(200, 20); } - if (value instanceof String){ + if (value instanceof String) { /* show default text in the list */ - String text=(String)value; + String text = (String) value; label.setText(text); label.setFont(new Font("Times New Roman", Font.BOLD, 12)); Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/ComboBoxRenderer.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/ComboBoxRenderer.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/ComboBoxRenderer.java (revision 32787) @@ -68,5 +68,5 @@ label.setIcon(icon); label.setText(text); - label.setFont( new Font("Times New Roman", Font.BOLD, 12)); + label.setFont(new Font("Times New Roman", Font.BOLD, 12)); return label; } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/renderer/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/RelevanceSlider.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/RelevanceSlider.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/RelevanceSlider.java (revision 32787) @@ -158,6 +158,6 @@ */ public int getUpperValue() { - if (upperValue 0) ? POSITIVE_SCROLL + int delta = incr * ((direction > 0) ? POSITIVE_SCROLL : NEGATIVE_SCROLL); if (isUpperSelected) { @@ -599,4 +599,3 @@ } } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/slider/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/ComponentUtil.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/ComponentUtil.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/ComponentUtil.java (revision 32787) @@ -72,6 +72,10 @@ * @version $Revision$ */ -public class ComponentUtil { - +public final class ComponentUtil { + + private ComponentUtil() { + // Hide default constructor for utilities classes + } + /** * Creates a JLabel object with the given properties. Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/component/util/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObservable.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObservable.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObservable.java (revision 32787) @@ -28,7 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.gui.observer; - import org.openstreetmap.josm.plugins.mapdust.gui.value.MapdustAction; - /** @@ -45,5 +43,5 @@ * @param observer The MapdustActionObserver object */ - public void addObserver(MapdustActionObserver observer); + void addObserver(MapdustActionObserver observer); /** @@ -52,5 +50,5 @@ * @param observer The MapdustActionObserver object */ - public void removeObserver(MapdustActionObserver observer); + void removeObserver(MapdustActionObserver observer); /** @@ -60,4 +58,4 @@ * @param mapdustAction The MapdustAction object */ - public void notifyObservers(MapdustAction mapdustAction); + void notifyObservers(MapdustAction mapdustAction); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObserver.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObserver.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustActionObserver.java (revision 32787) @@ -28,7 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.gui.observer; - import org.openstreetmap.josm.plugins.mapdust.gui.value.MapdustAction; - /** @@ -45,4 +43,4 @@ * @param mapdustAction The MapdustAction list */ - public void addAction(MapdustAction mapdustAction); + void addAction(MapdustAction mapdustAction); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObservable.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObservable.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObservable.java (revision 32787) @@ -28,7 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.gui.observer; - import org.openstreetmap.josm.plugins.mapdust.service.value.MapdustBug; - /** @@ -45,5 +43,5 @@ * @param observer The MapdustBugDetailsObserver object */ - public void addObserver(MapdustBugDetailsObserver observer); + void addObserver(MapdustBugDetailsObserver observer); /** @@ -52,5 +50,5 @@ * @param observer The MapdustBugDetailsObserver object */ - public void removeObserver(MapdustBugDetailsObserver observer); + void removeObserver(MapdustBugDetailsObserver observer); /** @@ -60,5 +58,4 @@ * @param mapdustBug The MapdustBug object */ - public void notifyObservers(MapdustBug mapdustBug); - + void notifyObservers(MapdustBug mapdustBug); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObserver.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObserver.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugDetailsObserver.java (revision 32787) @@ -28,7 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.gui.observer; - import org.openstreetmap.josm.plugins.mapdust.service.value.MapdustBug; - /** @@ -46,5 +44,4 @@ * @param mapdustBug The MapdustBug object */ - public void showDetails(MapdustBug mapdustBug); - + void showDetails(MapdustBug mapdustBug); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObservable.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObservable.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObservable.java (revision 32787) @@ -31,5 +31,4 @@ import org.openstreetmap.josm.plugins.mapdust.service.value.MapdustBug; - /** * The observable interface for the MapdustBug object. Observes the @@ -46,5 +45,5 @@ * @param observer The MapdustBugObserver object */ - public void addObserver(MapdustBugObserver observer); + void addObserver(MapdustBugObserver observer); /** @@ -53,5 +52,5 @@ * @param observer The MapdustBugObserver object */ - public void removeObserver(MapdustBugObserver observer); + void removeObserver(MapdustBugObserver observer); /** @@ -61,5 +60,4 @@ * @param mapdustBug The MapdustBug object */ - public void notifyObservers(MapdustBug mapdustBug); - + void notifyObservers(MapdustBug mapdustBug); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObserver.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObserver.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustBugObserver.java (revision 32787) @@ -28,7 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.gui.observer; - import org.openstreetmap.josm.plugins.mapdust.service.value.MapdustBug; - /** @@ -45,5 +43,4 @@ * @param mapdustBug A MapdustBug object */ - public void changedData(MapdustBug mapdustBug); - + void changedData(MapdustBug mapdustBug); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObservable.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObservable.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObservable.java (revision 32787) @@ -35,5 +35,4 @@ import org.openstreetmap.josm.plugins.mapdust.service.value.MapdustBugFilter; - /** * The observable interface for the MapDust bug update action. @@ -49,5 +48,5 @@ * @param observer The MapdustUpdateObserver object */ - public void addObserver(MapdustUpdateObserver observer); + void addObserver(MapdustUpdateObserver observer); /** @@ -56,5 +55,5 @@ * @param observer The MapdustUpdateObserver object */ - public void removeObserver(MapdustUpdateObserver observer); + void removeObserver(MapdustUpdateObserver observer); /** @@ -65,5 +64,4 @@ * or not. */ - public void notifyObservers(MapdustBugFilter filter, boolean initialUpdate); - + void notifyObservers(MapdustBugFilter filter, boolean initialUpdate); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObserver.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObserver.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/MapdustUpdateObserver.java (revision 32787) @@ -55,5 +55,4 @@ * or not. */ - public void update(MapdustBugFilter filter, boolean initialUpdate); - + void update(MapdustBugFilter filter, boolean initialUpdate); } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/observer/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustPluginState.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustPluginState.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustPluginState.java (revision 32787) @@ -51,5 +51,5 @@ * @param value The value of the object */ - private MapdustPluginState(String value) { + MapdustPluginState(String value) { this.value = value; } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustRelevanceValue.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustRelevanceValue.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustRelevanceValue.java (revision 32787) @@ -44,5 +44,5 @@ * @version $Revision$ */ -public class MapdustRelevanceValue { +public final class MapdustRelevanceValue { /** The low MapDust bug relevance value */ Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustServiceCommand.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustServiceCommand.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/MapdustServiceCommand.java (revision 32787) @@ -53,5 +53,5 @@ * Builds a new MapdustServiceCommand object */ - private MapdustServiceCommand() {} + MapdustServiceCommand() {} /** @@ -61,5 +61,5 @@ * @param value The value */ - private MapdustServiceCommand(String key, String value) { + MapdustServiceCommand(String key, String value) { this.key = key; this.value = value; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/gui/value/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/MapdustConverter.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/MapdustConverter.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/MapdustConverter.java (revision 32787) @@ -52,5 +52,9 @@ * */ -class MapdustConverter { +final class MapdustConverter { + + private MapdustConverter() { + // Hide default constructor for utilities classes + } /** Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnector.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnector.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnector.java (revision 32787) @@ -544,6 +544,5 @@ } } - - + private T parseResponse(String httpResponse, Class responseType) throws MapdustConnectorException { Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnectorException.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnectorException.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/MapdustConnectorException.java (revision 32787) @@ -77,4 +77,3 @@ super(message, cause); } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/GeneralContent.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/GeneralContent.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/GeneralContent.java (revision 32787) @@ -53,6 +53,5 @@ this.id = id; } - - + public Long getId() { return id; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/Geometry.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/Geometry.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/Geometry.java (revision 32787) @@ -28,5 +28,4 @@ package org.openstreetmap.josm.plugins.mapdust.service.connector.response; - /** * Defines the attributes of the geometry object. @@ -38,5 +37,5 @@ /** The array of coordinates */ - private Double coordinates[]; + private Double[] coordinates; /** @@ -53,9 +52,7 @@ this.coordinates = coordinates; } - - + public Double[] getCoordinates() { return coordinates; } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugContent.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugContent.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugContent.java (revision 32787) @@ -60,6 +60,5 @@ this.properties = properties; } - - + public Geometry getGeometry() { return geometry; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugProperties.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugProperties.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustBugProperties.java (revision 32787) @@ -132,6 +132,5 @@ this.comments = comments; } - - + public Date getDateCreated() { return dateCreated; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustCommentProperties.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustCommentProperties.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustCommentProperties.java (revision 32787) @@ -82,5 +82,4 @@ this.source = source; } - public Date getDateCreated() { @@ -91,5 +90,4 @@ return comment; } - public String getNickname() { Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugResponse.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugResponse.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugResponse.java (revision 32787) @@ -55,5 +55,5 @@ * Builds a MapdustGetBugResponse object * - * @param geometry The GeometryGeometry object * @param id The id of the object * @param properties The MapdustBugProperties object @@ -65,5 +65,4 @@ this.properties = properties; } - public Geometry getGeometry() { Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugsResponse.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugsResponse.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetBugsResponse.java (revision 32787) @@ -54,9 +54,7 @@ this.features = features; } - public MapdustBugContent[] getFeatures() { return features; } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetResponse.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetResponse.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustGetResponse.java (revision 32787) @@ -58,9 +58,7 @@ this.paging = paging; } - public Paging getPaging() { return paging; } - } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustPostResponse.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustPostResponse.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/MapdustPostResponse.java (revision 32787) @@ -28,5 +28,4 @@ package org.openstreetmap.josm.plugins.mapdust.service.connector.response; - /** * Represents a response object for the HTTP POST method. @@ -55,5 +54,4 @@ this.id = id; } - public Long getId() { Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/connector/response/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/MapdustResponseStatusCode.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/MapdustResponseStatusCode.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/MapdustResponseStatusCode.java (revision 32787) @@ -88,5 +88,5 @@ * @param description The description of the response */ - private MapdustResponseStatusCode(Integer statusCode, Integer apiCode, + MapdustResponseStatusCode(Integer statusCode, Integer apiCode, String description) { this.statusCode = statusCode; Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/RelevanceRange.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/RelevanceRange.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/RelevanceRange.java (revision 32787) @@ -45,5 +45,5 @@ * @version $Revision$ */ -public class RelevanceRange implements Serializable, Comparable { +public final class RelevanceRange implements Serializable, Comparable { /** The serial version UID */ Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/service/value/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/Configuration.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/Configuration.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/Configuration.java (revision 32787) @@ -39,5 +39,5 @@ * @author Bea */ -public class Configuration { +public final class Configuration { /** The instance of this singleton object type */ Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/HttpConnector.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/HttpConnector.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/HttpConnector.java (revision 32787) @@ -34,4 +34,5 @@ import java.io.InputStreamReader; import java.io.OutputStreamWriter; +import java.io.UnsupportedEncodingException; import java.net.HttpURLConnection; import java.net.URL; @@ -39,4 +40,5 @@ import java.util.Map; +import org.openstreetmap.josm.Main; import org.openstreetmap.josm.plugins.mapdust.util.retry.RetryAgent; import org.openstreetmap.josm.plugins.mapdust.util.retry.RetrySetup; @@ -230,5 +232,7 @@ buf.append(key).append("=").append(URLEncoder.encode( postParameters.get(key), "utf-8")); - } catch (java.io.UnsupportedEncodingException neverHappen) {} + } catch (UnsupportedEncodingException e) { + Main.error(e); + } i++; } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/http/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/package-info.java (revision 32787) Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryAgent.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryAgent.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryAgent.java (revision 32787) @@ -28,4 +28,5 @@ package org.openstreetmap.josm.plugins.mapdust.util.retry; +import org.openstreetmap.josm.Main; /** @@ -37,6 +38,6 @@ * the cleanup method. * + * @author rrainn * @param the type of the object returned by the target method - * @author rrainn */ public abstract class RetryAgent { @@ -129,5 +130,5 @@ Thread.sleep(delay); } catch (InterruptedException e1) { - // LOG.error(e1.getMessage(), e1); + Main.error(e1); // throw e; } @@ -139,5 +140,5 @@ } catch (Exception e) { /* if it can't be cleaned up, there's nothing to do */ - // LOG.error("Could not clean up", e); + Main.error("Could not clean up", e); } } @@ -172,5 +173,5 @@ Thread.sleep(delay); } catch (InterruptedException e1) { - // LOG.error(e1.getMessage(), e1); + Main.error(e1); throw e; } @@ -182,5 +183,5 @@ } catch (Exception e) { /* if it can't be cleaned up, there's nothing to do */ - // LOG.error("Could not clean up", e); + Main.error("Could not clean up", e); } } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryMode.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryMode.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetryMode.java (revision 32787) @@ -28,5 +28,4 @@ package org.openstreetmap.josm.plugins.mapdust.util.retry; - /** * The mode in which the {@link RetryAgent} should work. @@ -56,5 +55,5 @@ * @param name the name of the mode */ - private RetryMode(String name) { + RetryMode(String name) { this.name = name; } Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetrySetup.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetrySetup.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/RetrySetup.java (revision 32787) @@ -68,6 +68,6 @@ * Returns the method for computing time intervals between attempts. * + * @return the retry mode * @see RetryMode - * @return the retry mode */ public RetryMode getMode() { Index: /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/package-info.java =================================================================== --- /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/package-info.java (revision 32786) +++ /applications/editors/josm/plugins/mapdust/src/org/openstreetmap/josm/plugins/mapdust/util/retry/package-info.java (revision 32787)