Changeset 3040 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2010-02-25T00:18:42+01:00 (14 years ago)

Author:

mjulius

Message:

in DataSetMerger use PrimitiveId instead of UniqueId for mergedMap - UniqueIds are not unique across primitive types.

File:

• trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -35 +35 @@
     /**
      * A map of all primitives that got replaced with other primitives.
-     * Key is the primitive id in their dataset, the value is the id in my dataset
-     */
-    private final Map<Long, Long> mergedMap;
+     * Key is the PrimitiveId in their dataset, the value is the PrimitiveId in my dataset
+     */
+    private final Map<PrimitiveId, PrimitiveId> mergedMap;
     /** a set of primitive ids for which we have to fix references (to nodes and
      * to relation members) after the first phase of merging
@@ -58 +58 @@
         this.sourceDataSet = sourceDataSet;
         conflicts = new ConflictCollection();
-        mergedMap = new HashMap<Long, Long>();
+        mergedMap = new HashMap<PrimitiveId, PrimitiveId>();
         objectsWithChildrenToMerge = new HashSet<PrimitiveId>();
         deletedObjectsToUnlink = new HashSet<OsmPrimitive>();
@@ -106 +106 @@
                 }
                 if (target.hasEqualSemanticAttributes(source)) {
-                    mergedMap.put(source.getUniqueId(), target.getUniqueId());
+                    mergedMap.put(source.getPrimitiveId(), target.getPrimitiveId());
                     // copy the technical attributes from other
                     // version
@@ -131 +131 @@
         target.mergeFrom(source);
         targetDataSet.addPrimitive(target);
-        mergedMap.put(source.getUniqueId(), target.getUniqueId());
+        mergedMap.put(source.getPrimitiveId(), target.getPrimitiveId());
         objectsWithChildrenToMerge.add(source.getPrimitiveId());
     }
 
     protected OsmPrimitive getMergeTarget(OsmPrimitive mergeSource) throws IllegalStateException{
-        Long targetId = mergedMap.get(mergeSource.getUniqueId());
+        PrimitiveId targetId = mergedMap.get(mergeSource.getPrimitiveId());
         if (targetId == null)
             return null;
-        return targetDataSet.getPrimitiveById(targetId, mergeSource.getType());
+        return targetDataSet.getPrimitiveById(targetId);
     }
 
@@ -278 +278 @@
             return false;
         // found a corresponding target, remember it
-        mergedMap.put(source.getUniqueId(), target.getUniqueId());
+        mergedMap.put(source.getPrimitiveId(), target.getPrimitiveId());
 
         if (target.getVersion() > source.getVersion())