Changeset 2655 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetListModel.java

Timestamp:

2009-12-19T10:47:49+01:00 (14 years ago)

Author:

jttt

Message:

Fixed #4161 Major slowdown in recent versions, used correct pattern for listeners realized using CopyOnWriteArrayList

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetListModel.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetListModel.java

@@ -9 +9 @@
 import java.util.List;
 import java.util.Set;
-import java.util.logging.Logger;
 
 import javax.swing.DefaultListModel;
@@ -20 +19 @@
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.Storage;
 
 public class ChangesetListModel extends DefaultListModel  implements ChangesetCacheListener{
-    static private final Logger logger = Logger.getLogger(ChangesetListModel.class.getName());
+    //static private final Logger logger = Logger.getLogger(ChangesetListModel.class.getName());
 
     private final List<Changeset> data = new ArrayList<Changeset>();
+    private final Storage<Changeset> shownChangesets = new Storage<Changeset>();
     private DefaultListSelectionModel selectionModel;
 
@@ -63 +64 @@
     }
 
+    protected void addChangeset(Changeset changeset) {
+        if (shownChangesets.add(changeset)) {
+            setChangesets(shownChangesets);
+            updateModel();
+        }
+    }
+
+    protected void removeChangeset(Changeset changeset) {
+        if (shownChangesets.remove(changeset)) {
+            setChangesets(shownChangesets);
+            updateModel();
+        }
+    }
+
     protected void setChangesets(Collection<Changeset> changesets) {
+        shownChangesets.clear();
+        if (changesets != null) {
+            shownChangesets.addAll(changesets);
+        }
+        updateModel();
+    }
+
+    private void updateModel() {
         Set<Changeset> sel = getSelectedChangesets();
         data.clear();
-        if (changesets == null) {
-            fireContentsChanged(this, 0, getSize());
-            return;
-        }
-        data.addAll(changesets);
+        data.addAll(shownChangesets);
         ChangesetCache cache = ChangesetCache.getInstance();
         for (Changeset cs: data) {