Changeset 2655 in josm for trunk/src/org/openstreetmap/josm/data/Preferences.java

Timestamp:

2009-12-19T10:47:49+01:00 (14 years ago)

Author:

jttt

Message:

Fixed #4161 Major slowdown in recent versions, used correct pattern for listeners realized using CopyOnWriteArrayList

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -26 +26 @@
 import java.util.Map.Entry;
 import java.util.concurrent.CopyOnWriteArrayList;
-import java.util.logging.Logger;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -44 +43 @@
  */
 public class Preferences {
-    static private final Logger logger = Logger.getLogger(Preferences.class.getName());
+    //static private final Logger logger = Logger.getLogger(Preferences.class.getName());
 
     /**
@@ -131 +130 @@
 
     public void addPreferenceChangeListener(PreferenceChangedListener listener) {
-        if (listener != null && ! listeners.contains(listener)) {
-            listeners.add(listener);
+        if (listener != null) {
+            listeners.addIfAbsent(listener);
         }
     }
 
     public void removePreferenceChangeListener(PreferenceChangedListener listener) {
-        if (listener != null && listeners.contains(listener)) {
-            listeners.remove(listener);
-        }
+        listeners.remove(listener);
     }