Changeset 2626 in josm for trunk/src/org/openstreetmap/josm/gui/history

Timestamp:

2009-12-13T11:48:12+01:00 (14 years ago)

Author:

jttt

Message:

Fixed some of the warnings found by FindBugs

Location:

trunk/src/org/openstreetmap/josm/gui/history

Files:

• HistoryBrowserModel.java (modified) (1 diff)
• NodeListViewer.java (modified) (4 diffs)
• VersionTable.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -881 +881 @@
      *
      */
-    class HistoryPrimitiveBuilder extends AbstractVisitor {
+    static class HistoryPrimitiveBuilder extends AbstractVisitor {
         private HistoryOsmPrimitive clone;
 

trunk/src/org/openstreetmap/josm/gui/history/NodeListViewer.java

@@ -169 +169 @@
     }
 
-    class NodeListPopupMenu extends JPopupMenu {
+    static class NodeListPopupMenu extends JPopupMenu {
         private ZoomToNodeAction zoomToNodeAction;
         private ShowHistoryAction showHistoryAction;
@@ -189 +189 @@
     }
 
-    class ZoomToNodeAction extends AbstractAction {
+    static class ZoomToNodeAction extends AbstractAction {
         private PrimitiveId primitiveId;
 
@@ -235 +235 @@
     }
 
-    class ShowHistoryAction extends AbstractAction {
+    static class ShowHistoryAction extends AbstractAction {
         private PrimitiveId primitiveId;
 
@@ -302 +302 @@
     }
 
-    class DoubleClickAdapter extends MouseAdapter {
+    static class DoubleClickAdapter extends MouseAdapter {
         private JTable table;
         private ShowHistoryAction showHistoryAction;

trunk/src/org/openstreetmap/josm/gui/history/VersionTable.java

@@ -9 +9 @@
 import java.util.Observable;
 import java.util.Observer;
-import java.util.logging.Logger;
 
 import javax.swing.DefaultListSelectionModel;
@@ -28 +27 @@
  */
 public class VersionTable extends JTable implements Observer{
+    //private static Logger logger = Logger.getLogger(VersionTable.class.getName());
 
-    private static Logger logger = Logger.getLogger(VersionTable.class.getName());
     private VersionTablePopupMenu popupMenu;
 
@@ -114 +113 @@
     }
 
-    class ChangesetInfoAction extends AbstractInfoAction {
+    static class ChangesetInfoAction extends AbstractInfoAction {
         private HistoryOsmPrimitive primitive;
 
@@ -143 +142 @@
     }
 
-    class VersionTablePopupMenu extends JPopupMenu {
+    static class VersionTablePopupMenu extends JPopupMenu {
 
         private ChangesetInfoAction changesetInfoAction;