Changeset 2610 in josm for trunk/src/org/openstreetmap/josm/data/osm

Timestamp:

2009-12-11T22:33:14+01:00 (14 years ago)

Author:

mjulius

Message:

Fixes #4115 - bogus warning about nodes outside download area in JoinAreasAction
DataSet.getSelected*() now return collections of the proper primitive type

File:

• trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -293 +293 @@
      * Return selected nodes.
      */
-    public Collection<OsmPrimitive> getSelectedNodes() {
+    public Collection<Node> getSelectedNodes() {
         return getSelected(nodes);
     }
@@ -300 +300 @@
      * Return selected ways.
      */
-    public Collection<OsmPrimitive> getSelectedWays() {
+    public Collection<Way> getSelectedWays() {
         return getSelected(ways);
     }
@@ -307 +307 @@
      * Return selected relations.
      */
-    public Collection<OsmPrimitive> getSelectedRelations() {
+    public Collection<Relation> getSelectedRelations() {
         return getSelected(relations);
     }
@@ -315 +315 @@
      * @param list The collection from which the selected items are returned.
      */
-    private Collection<OsmPrimitive> getSelected(Collection<? extends OsmPrimitive> list) {
+    private <T extends OsmPrimitive> Collection<T> getSelected(Collection<T> list) {
         if (list == null)
-            return new LinkedList<OsmPrimitive>();
+            return new LinkedList<T>();
         // getSelected() is called with large lists, so
         // creating the return list from the selection
         // should be faster most of the time.
-        Collection<OsmPrimitive> sel = new LinkedHashSet<OsmPrimitive>(selectedPrimitives);
-        sel.retainAll(list);
+        Collection<T> sel = new LinkedHashSet<T>(list);
+        sel.retainAll(selectedPrimitives);
         return sel;
     }