Changeset 2256 in josm for trunk/src/org/openstreetmap/josm/actions/ReverseWayAction.java

Timestamp:

2009-10-09T17:16:54+02:00 (15 years ago)

Author:

Gubaer

Message:

Removed inefficient DataSet:getSelected() when responding to fireSelectionChanged() in JOSM actions, see ​thread on dev
Still uses DataSet:getSelected() when responding to layer change events, this is less critical.

File:

• trunk/src/org/openstreetmap/josm/actions/ReverseWayAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/ReverseWayAction.java

@@ -97 +97 @@
     @Override
     protected void updateEnabledState() {
-        setEnabled(getNumWaysInSelection() > 0);
+        if (getCurrentDataSet() == null) {
+            setEnabled(false);
+        } else {
+            updateEnabledState(getCurrentDataSet().getSelected());
+        }
+    }
+
+    @Override
+    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
+        if (selection == null) {
+            setEnabled(false);
+            return;
+        }
+        int n = 0;
+        for (OsmPrimitive primitive : selection) {
+            if (primitive instanceof Way) {
+                n++;
+            }
+        }
+        setEnabled(n > 0);
     }
 }