Index: applications/editors/josm/plugins/tracer/build.xml
===================================================================
--- applications/editors/josm/plugins/tracer/build.xml	(revision 19862)
+++ applications/editors/josm/plugins/tracer/build.xml	(revision 19863)
@@ -1,4 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <!--
-** This is the build file for the tracer
+** This is a build file for a JOSM  plugin "Tracer".
 **
 ** Maintaining versions
@@ -12,80 +13,148 @@
 **    > ant  dist
 **
-** To install the generated plugin locally (in your default plugin directory) run
+** To install the generated plugin locally (in you default plugin directory) run
 **
 **    > ant  install
 **
-** To build against the core in ../../core, create a correct manifest and deploy to
-** SVN, run
-**    - set the property commit.message
-**    - set the property plugin.main.version to lowest JOSM release number this
-**      plugin build is compatible with
-**    > ant  deploy
+** The generated plugin jar is not automatically available in JOSMs plugin configuration
+** dialog. You have to check it in first.
+**
+** Use the ant target 'publish' to check in the plugin and make it available to other
+** JOSM users:
+**    set the properties commit.message and plugin.main.version
+** and run
+**    > ant  publish
 **
 **
 -->
-<project name="tracer" default="dist" basedir=".">
-
-
-	<property name="commit.message" value="Made build file more robust, mainly in case svn is missing on the build machine" />
-	<property name="plugin.main.version" value="2450" />
-
-
-	<property name="josm" location="../../core/dist/josm-custom.jar" />
-	<property name="plugin.dist.dir" value="../../dist" />
-	<property name="plugin.build.dir" value="build" />
-	<property name="plugin.jar" value="${plugin.dist.dir}/${ant.project.name}.jar" />
-	<property name="ant.build.javac.target" value="1.5" />
-
+<project name="Tracer" default="dist" basedir=".">
+
+	<!-- enter the SVN commit message -->
+	<property name="commit.message" value="build.xml according to official template" />
+	<!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
+	<property name="plugin.main.version" value="2561" />
+
+
+	<!--
+      ************************************************
+      ** should not be necessary to change the following properties
+     -->
+	<property name="josm"                   location="../../core/dist/josm-custom.jar"/>
+	<property name="plugin.build.dir"       value="build"/>
+	<property name="plugin.src.dir"         value="src"/>
+	<!-- this is the directory where the plugin jar is copied to -->
+	<property name="plugin.dist.dir"        value="../../dist"/>
+	<property name="ant.build.javac.target" value="1.5"/>
+	<property name="plugin.dist.dir"        value="../../dist"/>
+	<property name="plugin.jar"             value="${plugin.dist.dir}/${ant.project.name}.jar"/>
+
+	<!--
+    **********************************************************
+    ** init - initializes the build
+    **********************************************************
+    -->
 	<target name="init">
-		<mkdir dir="${plugin.build.dir}" />
-	</target>
+		<mkdir dir="${plugin.build.dir}"/>
+	</target>
+
+	<!--
+    **********************************************************
+    ** compile - complies the source tree
+    **********************************************************
+    -->
 	<target name="compile" depends="init">
-		<echo message="creating ${plugin.jar}" />
+		<echo message="compiling sources for  ${plugin.jar} ... "/>
 		<javac srcdir="src" classpath="${josm}" debug="true" destdir="${plugin.build.dir}">
-			<compilerarg value="-Xlint:deprecation" />
-			<compilerarg value="-Xlint:unchecked" />
+			<compilerarg value="-Xlint:deprecation"/>
+			<compilerarg value="-Xlint:unchecked"/>
 		</javac>
 	</target>
+
+	<!--
+    **********************************************************
+    ** dist - creates the plugin jar
+    **********************************************************
+    -->
 	<target name="dist" depends="compile,revision">
-		<echo message="building ${plugin.jar} with version ${version.entry.commit.revision} for JOSM version ${josm.reference.release} " />
+		<echo message="creating ${ant.project.name}.jar ... "/>
+		<!--
+		<copy todir="${plugin.build.dir}/resources">
+			<fileset dir="resources"/>
+		</copy>
+		-->
 		<copy todir="${plugin.build.dir}/images">
-			<fileset dir="images" />
+			<fileset dir="images"/>
+		</copy>
+		<copy todir="${plugin.build.dir}">
+			<fileset dir=".">
+				<include name="README" />
+				<include name="LICENSE" />
+			</fileset>
 		</copy>
 		<jar destfile="${plugin.jar}" basedir="${plugin.build.dir}">
+			<!--
+        ************************************************
+        ** configure these properties. Most of them will be copied to the plugins
+        ** manifest file. Property values will also show up in the list available
+        ** plugins: http://josm.openstreetmap.de/wiki/Plugins.
+        **
+        ************************************************
+    -->
 			<manifest>
-				<attribute name="Author" value="Jan Bilak, Petr Dlouhý" />
-				<attribute name="Plugin-Class" value="tracer.TracerPlugin" />
-				<attribute name="Plugin-Date" value="${version.entry.commit.date}" />
-				<attribute name="Plugin-Description" value="Traces buildings from Czech cadastral map. Needs TracerServer (.NET or Mono) to be runnign." />
-				<!-- <attribute name="Plugin-Link" value="http://wiki.openstreetmap.org/wiki/JOSM/Plugins/Tracer" /> -->
-				<attribute name="Plugin-Mainversion" value="${plugin.main.version}" />
-				<attribute name="Plugin-Version" value="${version.entry.commit.revision}" />
+				<attribute name="Author" value="..."/>
+				<attribute name="Plugin-Class" value="..."/>
+				<attribute name="Plugin-Date" value="${version.entry.commit.date}"/>
+				<attribute name="Plugin-Description" value="..."/>
+				<attribute name="Plugin-Link" value="..."/>
+				<attribute name="Plugin-Mainversion" value="${plugin.main.version}"/>
+				<attribute name="Plugin-Version" value="${version.entry.commit.revision}"/>
 			</manifest>
 		</jar>
 	</target>
+
+	<!--
+    **********************************************************
+    ** revision - extracts the current revision number for the
+    **    file build.number and stores it in the XML property
+    **    version.*
+    **********************************************************
+    -->
 	<target name="revision">
-		<exec append="false" output="REVISION" executable="svn" failifexecutionfails="true" failonerror="true">
-			<env key="LANG" value="C" />
-			<arg value="info" />
-			<arg value="--xml" />
-			<arg value="." />
-		</exec>
-		<xmlproperty file="REVISION" prefix="version" keepRoot="false" collapseAttributes="true" />
-		<delete file="REVISION" />
-	</target>
+
+		<exec append="false" output="REVISION" executable="svn" failifexecutionfails="false">
+			<env key="LANG" value="C"/>
+			<arg value="info"/>
+			<arg value="--xml"/>
+			<arg value="."/>
+		</exec>
+		<xmlproperty file="REVISION" prefix="version" keepRoot="false" collapseAttributes="true"/>
+		<delete file="REVISION"/>
+	</target>
+
+	<!--
+    **********************************************************
+    ** clean - clean up the build environment
+    **********************************************************
+    -->
 	<target name="clean">
-		<delete dir="${plugin.build.dir}" />
-		<delete file="${plugin.jar}" />
-	</target>
+		<delete dir="${plugin.build.dir}"/>
+		<delete file="${plugin.jar}"/>
+	</target>
+
+	<!--
+    **********************************************************
+    ** install - install the plugin in your local JOSM installation
+    **********************************************************
+    -->
 	<target name="install" depends="dist">
-		<property environment="env" />
+		<property environment="env"/>
 		<condition property="josm.plugins.dir" value="${env.APPDATA}/JOSM/plugins" else="${user.home}/.josm/plugins">
 			<and>
-				<os family="windows" />
+				<os family="windows"/>
 			</and>
 		</condition>
-		<copy file="${plugin.jar}" todir="${josm.plugins.dir}" />
-	</target>
+		<copy file="${plugin.jar}" todir="${josm.plugins.dir}"/>
+	</target>
+
 
 	<!--
@@ -93,16 +162,16 @@
 	-->
 	<!--
-	** extracts the JOSM release for the JOSM version in ../core and saves it in the 
-	** property ${coreversion.info.entry.revision}
-	**
-	-->
+		** extracts the JOSM release for the JOSM version in ../core and saves it in the 
+		** property ${coreversion.info.entry.revision}
+		**
+		-->
 	<target name="core-info">
 		<exec append="false" output="core.info.xml" executable="svn" failifexecutionfails="false">
-			<env key="LANG" value="C" />
-			<arg value="info" />
-			<arg value="--xml" />
-			<arg value="../../core" />
-		</exec>
-		<xmlproperty file="core.info.xml" prefix="coreversion" keepRoot="true" collapseAttributes="true" />
+			<env key="LANG" value="C"/>
+			<arg value="info"/>
+			<arg value="--xml"/>
+			<arg value="../../core"/>
+		</exec>
+		<xmlproperty file="core.info.xml" prefix="coreversion" keepRoot="true" collapseAttributes="true"/>
 		<echo>Building against core revision ${coreversion.info.entry.revision}.</echo>
 		<echo>Plugin-Mainversion is set to ${plugin.main.version}.</echo>
@@ -111,37 +180,37 @@
 
 	<!--
-	** commits the source tree for this plugin
-	-->
+		** commits the source tree for this plugin
+		-->
 	<target name="commit-current">
 		<echo>Commiting the plugin source with message '${commit.message}' ...</echo>
-		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="true" failonerror="true">
-			<env key="LANG" value="C" />
-			<arg value="commit" />
-			<arg value="-m '${commit.message}'" />
-			<arg value="." />
-		</exec>
-	</target>
-
-	<!--
-	** updates (svn up) the source tree for this plugin
-	-->
+		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="false">
+			<env key="LANG" value="C"/>
+			<arg value="commit"/>
+			<arg value="-m '${commit.message}'"/>
+			<arg value="."/>
+		</exec>
+	</target>
+
+	<!--
+		** updates (svn up) the source tree for this plugin
+		-->
 	<target name="update-current">
 		<echo>Updating plugin source ...</echo>
-		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="true" failonerror="true">
-			<env key="LANG" value="C" />
-			<arg value="up" />
-			<arg value="." />
+		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="false">
+			<env key="LANG" value="C"/>
+			<arg value="up"/>
+			<arg value="."/>
 		</exec>
 		<echo>Updating ${plugin.jar} ...</echo>
-		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="true" failonerror="true">
-			<env key="LANG" value="C" />
-			<arg value="up" />
-			<arg value="../dist/${plugin.jar}" />
-		</exec>
-	</target>
-
-	<!--
-	** commits the plugin.jar 
-	-->
+		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="false">
+			<env key="LANG" value="C"/>
+			<arg value="up"/>
+			<arg value="../dist/${plugin.jar}"/>
+		</exec>
+	</target>
+
+	<!--
+		** commits the plugin.jar 
+		-->
 	<target name="commit-dist">
 		<echo>
@@ -155,20 +224,28 @@
 	Now commiting ${plugin.jar} ...
 	</echo>
-		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="true" failonerror="true">
-			<env key="LANG" value="C" />
-			<arg value="-m '${commit.message}'" />
-			<arg value="commit" />
-			<arg value="${plugin.jar}" />
-		</exec>
-	</target>
-
+		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="false">
+			<env key="LANG" value="C"/>
+			<arg value="-m '${commit.message}'"/>
+			<arg value="commit"/>
+			<arg value="${plugin.jar}"/>
+		</exec>
+	</target>
 
 	<!-- ** make sure svn is present as a command line tool ** -->
 	<target name="ensure-svn-present">
-		<exec append="true" output="svn.log" executable="svn" failonerror="false" resultproperty="svn.exit.code">
+		<exec append="true" output="svn.log" executable="svn" failifexecutionfails="false" failonerror="false" resultproperty="svn.exit.code">
 			<env key="LANG" value="C" />
 			<arg value="--version" />
 		</exec>
-		<fail message="Fatal: command 'svn' not found. Please make sure svn is installed on your system.">
+		<fail message="Fatal: command 'svn --version' failed. Please make sure svn is installed on your system.">
+			<!-- return code not set at all? Most likely svn isn't installed -->
+			<condition>
+				<not>
+					<isset property="svn.exit.code" />
+				</not>
+			</condition>
+		</fail>
+		<fail message="Fatal: command 'svn --version' failed. Please make sure a working copy of svn is installed on your system.">
+			<!-- error code from SVN? Most likely svn is not what we are looking on this system -->
 			<condition>
 				<isfailure code="${svn.exit.code}" />