Changeset 19535 in josm for trunk/src/org/openstreetmap/josm/plugins

Timestamp:

2026-02-20T11:51:47+01:00 (3 months ago)

Author:

stoecker

Message:

remove a lot of PMD warnings, especially outdated ignores, see #24635

Location:

trunk/src/org/openstreetmap/josm/plugins

Files:

• PluginClassLoader.java (modified) (2 diffs)
• PluginHandler.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/plugins/PluginClassLoader.java

@@ -89 +89 @@
      * @return the class, if found, otherwise {@code null}
      */
-    @SuppressWarnings("PMD.CloseResource") // NOSONAR We do *not* want to close class loaders in this method...
     private Class<?> findClassInDependencies(String name, boolean resolve) {
         for (PluginClassLoader dep : dependencies) {
@@ -106 +105 @@
 
     @Override
-    @SuppressWarnings("PMD.CloseResource") // NOSONAR We do *not* want to close class loaders in this method...
     public URL findResource(String name) {
         URL resource = super.findResource(name);

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -831 +831 @@
      * @param plugins the plugins to add
      */
-    @SuppressWarnings("PMD.CloseResource") // NOSONAR We do *not* want to close class loaders in this method...
     private static void extendJoinedPluginResourceCL(Collection<PluginInformation> plugins) {
         // iterate all plugins and collect all libraries of all plugins:
@@ -877 +876 @@
                         + "Delete from preferences?</html>", "'"+Utils.escapeReservedCharactersHTML(plugin.name)+"'", plugin.className);
             }
-        } catch (RuntimeException e) { // NOPMD
+        } catch (RuntimeException e) {
             pluginLoadingExceptions.put(plugin.name, e);
             Logging.error(e);
@@ -937 +936 @@
      * @param toLoad The plugins to generate the classloaders for
      */
-    @SuppressWarnings({"squid:S2095", "PMD.CloseResource"}) // NOSONAR the classloaders and put in a map which we want to keep.
+    @SuppressWarnings("squid:S2095") // NOSONAR the classloaders and put in a map which we want to keep.
     private static void generateClassloaders(List<PluginInformation> toLoad) {
         for (PluginInformation info : toLoad) {
@@ -953 +952 @@
      * @param toLoad The plugins to resolve dependencies for
      */
-    @SuppressWarnings({"squid:S2095", "PMD.CloseResource"}) // NOSONAR the classloaders are from a persistent map
+    @SuppressWarnings("squid:S2095") // NOSONAR the classloaders are from a persistent map
     private static void resolveDependencies(List<PluginInformation> toLoad) {
         for (PluginInformation info : toLoad) {