Changeset 1901 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2009-08-04T07:51:57+02:00 (15 years ago)

Author:

Gubaer

Message:

temporary fix for #3181: Dialogs causes JOSM window to be set as "always on top", preventing switchiong to other windows.

File:

• trunk/src/org/openstreetmap/josm/gui/OptionPaneUtil.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/OptionPaneUtil.java

@@ -42 +42 @@
      */
     static protected void prepareDialog(JDialog dialog) {
-        try {
-            dialog.setAlwaysOnTop(true);
-        } catch(SecurityException e) {
-            System.out.println(tr("Warning: failed to put option pane dialog always on top. Exception was: {0}", e.toString()));
+
+        // always on top can be disabled in a configuration option. This is necessary
+        // for some WM on Linux, i.e. fluxbox. There, always-on-top propagates to the
+        // parent window, i.e. the JOSM window itself.
+        //
+        // FIXME: this is a temporary solution. I'm still looking for an approach which
+        // works across all OS and WMs. Can we get rid of "always-on-top" in JOSM
+        // completely?
+        //
+        if (Main.pref.getBoolean("window-handling.option-pane-always-on-top", true)) {
+            try {
+                dialog.setAlwaysOnTop(true);
+            } catch(SecurityException e) {
+                System.out.println(tr("Warning: failed to put option pane dialog always on top. Exception was: {0}", e.toString()));
+            }
         }
         dialog.setModal(true);