Changeset 18893 in josm for trunk/test/unit/org/openstreetmap/josm/spi/lifecycle

Timestamp:

2023-11-02T13:14:51+01:00 (2 years ago)

Author:

taylor.smock

Message:

Fix #16567: Upgrade to JUnit 5

JOSMTestRules and JOSMTestFixture can reset the default JOSM profile, which can
be unexpected for new contributors. This updates all tests to use JUnit 5 and
the new JUnit 5 annotations.

This also renames MapCSSStyleSourceFilterTest to MapCSSStyleSourceFilterPerformanceTest
to match the naming convention for performance tests and fixes some lint issues.

This was tested by running all tests individually and together.

File:

• trunk/test/unit/org/openstreetmap/josm/spi/lifecycle/LifecycleTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/spi/lifecycle/LifecycleTest.java

@@ -5 +5 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.api.Test;
-import org.openstreetmap.josm.testutils.JOSMTestRules;
-
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import org.openstreetmap.josm.testutils.annotations.HTTPS;
+import org.openstreetmap.josm.testutils.annotations.Main;
+import org.openstreetmap.josm.testutils.annotations.OsmApi;
+import org.openstreetmap.josm.testutils.annotations.Projection;
 
 /**
  * Unit tests of {@link Lifecycle} class.
  */
+@HTTPS
+@Main
+@OsmApi(OsmApi.APIType.DEV)
+@Projection
 class LifecycleTest {
-
-    /**
-     * Setup test.
-     */
-    @RegisterExtension
-    @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().https().devAPI().main().projection();
-
     private static class InitStatusListenerStub implements InitStatusListener {