Changeset 18871 in josm for trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadDataHandler.java

Timestamp:

2023-10-16T19:03:11+02:00 (14 months ago)

Author:

taylor.smock

Message:

See #23218: Use newer error_prone versions when compiling on Java 11+

error_prone 2.11 dropped support for compiling with Java 8, although it still
supports compiling for Java 8. The "major" new check for us is NotJavadoc since
we used /** in quite a few places which were not javadoc.

Other "new" checks that are of interest:

• AlreadyChecked: if (foo) { doFoo(); } else if (!foo) { doBar(); }
• UnnecessaryStringBuilder: Avoid StringBuilder (Java converts + to StringBuilder behind-the-scenes, but may also do something else if it performs better)
• NonApiType: Avoid specific interface types in function definitions
• NamedLikeContextualKeyword: Avoid using restricted names for classes and methods
• UnusedMethod: Unused private methods should be removed

This fixes most of the new error_prone issues and some SonarLint issues.

File:

• trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadDataHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadDataHandler.java

@@ -82 +82 @@
         validateDownloadParams();
         this.data = args.get("data");
-        /**
+        /*
          * Holds the mime type. Currently only OSM_MIME_TYPE is supported
          * But it could be extended to text/csv, application/gpx+xml, ... or even binary encoded data