Changeset 18394 in josm for trunk/test/unit/org/openstreetmap/josm/gui/layer

Timestamp:

2022-03-12T08:18:43+01:00 (2 years ago)

Author:

GerdP

Message:

see #21740: IAE: Attempted to add listener that was already in list: external preset with group name RoadSigns

• improve unit test (patch by Bjoeni)

File:

• trunk/test/unit/org/openstreetmap/josm/gui/layer/MainLayerManagerTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/layer/MainLayerManagerTest.java

@@ -3 +3 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertSame;
-
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
+import java.util.logging.Handler;
+import java.util.logging.LogRecord;
 
 import org.junit.jupiter.api.BeforeAll;
@@ -54 +58 @@
             return LayerPositionStrategy.afterLast(o -> true);
         }
+    }
+
+    protected static class LoggingHandler extends Handler {
+
+        private List<LogRecord> records = new ArrayList<>();
+
+        @Override
+        public void publish(LogRecord record) {
+            records.add(record);
+        }
+
+        @Override
+        public void flush() {}
+
+        @Override
+        public void close() throws SecurityException {}
+
+        public List<LogRecord> getRecords() {
+            return records;
+        }
+
     }
 
@@ -146 +171 @@
     void testAddActiveLayerChangeListenerTwice() {
         CapturingActiveLayerChangeListener listener = new CapturingActiveLayerChangeListener();
+        LoggingHandler handler = new LoggingHandler();
+        Logging.getLogger().addHandler(handler);
+
         layerManagerWithActive.addActiveLayerChangeListener(listener);
-        Logging.clearLastErrorAndWarnings();
+        assertTrue(handler.getRecords().isEmpty());
+
         layerManagerWithActive.addActiveLayerChangeListener(listener);
-        assertFalse(Logging.getLastErrorAndWarnings().isEmpty());
+        assertTrue(handler.getRecords().get(1).getMessage().startsWith("Attempted to add listener that was already in list"));
+
+        Logging.getLogger().removeHandler(handler);
     }
 
@@ -175 +206 @@
     @Test
     void testRemoveActiveLayerChangeListenerNotInList() {
-        Logging.clearLastErrorAndWarnings();
+        LoggingHandler handler = new LoggingHandler();
+        Logging.getLogger().addHandler(handler);
+
         layerManagerWithActive.removeActiveLayerChangeListener(new CapturingActiveLayerChangeListener());
-        assertFalse(Logging.getLastErrorAndWarnings().isEmpty());
+        assertTrue(handler.getRecords().get(1).getMessage().startsWith("Attempted to remove listener that was not in list"));
+
+        Logging.getLogger().removeHandler(handler);
     }