Changeset 17489 in josm for trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

Timestamp:

2021-02-10T08:45:14+01:00 (3 years ago)

Author:

GerdP

Message:

fix #20455: Raise "Unclosed way - landuse" warnings to errors

• Raise warning to error for those checks where we know that the tag must describe an area

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

@@ -96 +96 @@
             String value = w.get(key);
             if (isValueErroneous(value)) {
-                return TestError.builder(test, Severity.WARNING, code)
+                final Severity severity;
+                // see #20455: raise severity to error when we are sure that tag key must describe an area
+                if (ignore && !specialValues.isEmpty()) {
+                    severity = Severity.WARNING;
+                } else {
+                    severity = Severity.ERROR;
+                }
+                return TestError.builder(test, severity, code)
                         .message(tr("Unclosed way"), engMessage, engMessage.contains("{0}") ? new Object[]{value} : new Object[]{})
                         .primitives(w)