Changeset 17458 in josm for trunk/src/org/openstreetmap/josm/actions/relation/AbstractRelationAction.java

Timestamp:

2021-01-13T15:26:08+01:00 (3 years ago)

Author:

GerdP

Message:

see #17184: Memory leaks

• clear collection rememberMovements in OrthogonalizeAction when no edit layer exits
• clear refs to layers which may disturb GC, maybe because of the complex cyclic deps

File:

• trunk/src/org/openstreetmap/josm/actions/relation/AbstractRelationAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/relation/AbstractRelationAction.java

@@ -16 +16 @@
 import org.openstreetmap.josm.io.NetworkManager;
 import org.openstreetmap.josm.io.OnlineResource;
+import org.openstreetmap.josm.tools.Destroyable;
 import org.openstreetmap.josm.tools.SubclassFilteredCollection;
 import org.openstreetmap.josm.tools.Utils;
@@ -25 +26 @@
  * @since 13957 (signature)
  */
-public abstract class AbstractRelationAction extends AbstractAction implements IPrimitiveAction {
+public abstract class AbstractRelationAction extends AbstractAction implements IPrimitiveAction, Destroyable {
     /** relation collection */
     protected transient Collection<IRelation<?>> relations = Collections.<IRelation<?>>emptySet();
@@ -72 +73 @@
         putValue("help", helpId);
     }
+
+    @Override
+    public void destroy() {
+        relations = null;
+    }
 }