Changeset 17436 in josm for trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java

Timestamp:

2021-01-04T11:54:31+01:00 (3 years ago)

Author:

GerdP

Message:

see #20342: Validator results not cleared

• make sure that validator tree is rebuild even if all found errors are ignored (regression from r13893)

File:

• trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java

@@ -79 +79 @@
         }
 
-        if (ValidatorPrefHelper.PREF_USE_IGNORE.get()) {
-            boolean allIgnored = true;
-            for (TestError error : errors) {
-                if (!error.updateIgnored()) {
-                    allIgnored = false;
-                }
-            }
-            if (allIgnored)
-                return true;
+        if (Boolean.TRUE.equals(ValidatorPrefHelper.PREF_USE_IGNORE.get())) {
+            errors.forEach(TestError::updateIgnored);
         }
 
@@ -99 +92 @@
             map.validatorDialog.tree.setErrors(errors);
         }
-        if (errors.isEmpty())
+        if (errors.stream().allMatch(TestError::isIgnored))
             return true;