Changeset 17399 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2020-12-09T08:27:45+01:00 (3 years ago)

Author:

GerdP

Message:

fix #20213: Command stack: Edits in relation editor are listed in wrong stack and lead to exception

• revert changes for #17196, this approach was too simple because relation editor may save changes for an inactive edit layer

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/UndoRedoHandler.java (modified) (6 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/dialogs/CommandStackDialog.java (modified) (4 diffs)
• gui/io/AsynchronousUploadPrimitivesTask.java (modified) (1 diff)
• gui/layer/OsmDataLayer.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java

@@ -4 +4 @@
 import java.util.Collections;
 import java.util.EventObject;
-import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.Map;
 import java.util.Objects;
 
@@ -13 +11 @@
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.OsmDataManager;
-import org.openstreetmap.josm.gui.MainApplication;
-import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.spi.preferences.Config;
@@ -45 +41 @@
 
     private static class InstanceHolder {
-        static final UndoRedoHandler NO_DATA_SET_INSTANCE = new UndoRedoHandler();
-        static final Map<DataSet, UndoRedoHandler> map = new HashMap<>();
-
+        static final UndoRedoHandler INSTANCE = new UndoRedoHandler();
     }
 
@@ -56 +50 @@
      */
     public static UndoRedoHandler getInstance() {
-        OsmDataLayer editLayer = MainApplication.getLayerManager().getEditLayer();
-        if (editLayer != null && editLayer == MainApplication.getLayerManager().getActiveLayer()) {
-            return InstanceHolder.map.computeIfAbsent(editLayer.data, k -> new UndoRedoHandler());
-        }
-        return InstanceHolder.NO_DATA_SET_INSTANCE;
+        return InstanceHolder.INSTANCE;
     }
 
@@ -443 +433 @@
             l.commandChanged(commands.size(), redoCommands.size());
         }
-        if (getInstance() != InstanceHolder.NO_DATA_SET_INSTANCE) {
-            for (final CommandQueueListener l : InstanceHolder.NO_DATA_SET_INSTANCE.listenerCommands) {
-                l.commandChanged(commands.size(), redoCommands.size());
-            }
-
-        }
     }
 
@@ -470 +454 @@
      * @since 12718
      */
-    public static synchronized void clean(DataSet dataSet) {
+    public synchronized void clean(DataSet dataSet) {
         if (dataSet == null)
             return;
-        UndoRedoHandler old = InstanceHolder.map.remove(dataSet);
-        if (old != null) {
-            old.clean();
+        boolean changed = false;
+        changed |= commands.removeIf(c -> c.getAffectedDataSet() == dataSet);
+        changed |= redoCommands.removeIf(c -> c.getAffectedDataSet() == dataSet);
+        if (changed) {
+            fireEvent(new CommandQueueCleanedEvent(this, dataSet));
+            fireCommandsChanged();
         }
     }

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -222 +222 @@
             Layer layer = e.getRemovedLayer();
             if (layer instanceof OsmDataLayer) {
-                UndoRedoHandler.clean(((OsmDataLayer) layer).getDataSet());
+                UndoRedoHandler.getInstance().clean(((OsmDataLayer) layer).getDataSet());
             }
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java

@@ -51 +51 @@
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.SideButton;
-import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeEvent;
-import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeListener;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.widgets.PopupMenuLauncher;
@@ -65 +63 @@
  * @since 94
  */
-public class CommandStackDialog extends ToggleDialog implements CommandQueuePreciseListener, ActiveLayerChangeListener {
+public class CommandStackDialog extends ToggleDialog implements CommandQueuePreciseListener {
 
     private final DefaultTreeModel undoTreeModel = new DefaultTreeModel(new DefaultMutableTreeNode());
@@ -147 +145 @@
         InputMapUtils.addEnterAction(undoTree, selectAndZoomAction);
         InputMapUtils.addEnterAction(redoTree, selectAndZoomAction);
-        MainApplication.getLayerManager().addActiveLayerChangeListener(this);
     }
 
@@ -556 +553 @@
         }
     }
-
-    @Override
-    public void activeOrEditLayerChanged(ActiveLayerChangeEvent e) {
-        hideNotify();
-        showNotify();
-    }
 }

trunk/src/org/openstreetmap/josm/gui/io/AsynchronousUploadPrimitivesTask.java

@@ -121 +121 @@
         GuiHelper.runInEDTAndWait(() -> {
             // Remove the commands from the undo stack
-            UndoRedoHandler.clean(uploadDataLayer.getDataSet());
+            UndoRedoHandler.getInstance().clean(uploadDataLayer.getDataSet());
             MainApplication.getLayerManager().prepareLayerForUpload(uploadDataLayer);
 

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -654 +654 @@
             return;
 
-        UndoRedoHandler.clean(data);
+        UndoRedoHandler.getInstance().clean(data);
 
         // if uploaded, clean the modified flags as well