Changeset 17141 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2020-10-10T11:48:49+02:00 (4 years ago)

Author:

GerdP

Message:

see #19885: memory leak with "temporary" objects in validator and actions
next bunch of changes:

• use ChangeNodesCommand instead of ChangeCommand
• further simplifications

File:

• trunk/src/org/openstreetmap/josm/tools/Geometry.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/Geometry.java

@@ -22 +22 @@
 
 import org.openstreetmap.josm.command.AddCommand;
-import org.openstreetmap.josm.command.ChangeCommand;
+import org.openstreetmap.josm.command.ChangeNodesCommand;
 import org.openstreetmap.josm.command.Command;
 import org.openstreetmap.josm.data.coor.EastNorth;
@@ -231 +231 @@
 
         for (int pos = 0; pos < ways.size(); pos++) {
-            if (!changedWays[pos]) {
-                continue;
-            }
-
-            Way way = ways.get(pos);
-            Way newWay = new Way(way);
-            newWay.setNodes(newNodes[pos]);
-
-            cmds.add(new ChangeCommand(dataset, way, newWay));
+            if (changedWays[pos]) {
+                cmds.add(new ChangeNodesCommand(dataset, ways.get(pos), newNodes[pos]));
+            }
         }