Changeset 17105 in josm

Timestamp:

2020-10-07T20:43:06+02:00 (4 years ago)

Author:

Klumbumbus

Message:

fix #17498 - Warn about bicycle=no and cycleway="something positive" (patch by Famlam, added none in the rules and some asserts from the linked osmose implementation)

Location:

trunk/resources/data/validator

Files:

• combinations.mapcss (modified) (1 diff)
• geometry.mapcss (modified) (1 diff)

trunk/resources/data/validator/combinations.mapcss

@@ -854 +854 @@
   assertNoMatch: "way footway=sidewalk abandoned:highway=unclassified";
 }
+
+/* #17498 */
+way[bicycle][/^cycleway(:|$)/][!/^bicycle:/][bicycle=~/^(no|none|use_sidepath)$/][/^cycleway(:|$)/!~/^(no|none|separate)$/] {
+  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
+  group: tr("suspicious tag combination");
+  assertMatch: "way bicycle=no cycleway=track";
+  assertMatch: "way bicycle=use_sidepath cycleway=lane";
+  assertMatch: "way bicycle=use_sidepath cycleway:left=lane";
+  assertNoMatch: "way bicycle=use_sidepath cycleway=no";
+  assertNoMatch: "way bicycle=use_sidepath bicycle:backward=yes cycleway:left=lane"; /* instead of :backward, could also be :forward or :conditional */
+  assertNoMatch: "way bicycle=no cycleway:right=no";
+  assertNoMatch: "way bicycle=use_sidepath cycleway:left=none";
+  assertNoMatch: "way highway=cycleway cycleway=separate";
+  assertNoMatch: "way highway=residential bicycle=use_sidepath";
+}

trunk/resources/data/validator/geometry.mapcss

@@ -145 +145 @@
 }
 way[building][building!=no] > node[!entrance].node_in_closed_highway {
-  set node_connects_highway_and_building; /* avoids duplicate warnings with folowing rule */
+  set node_connects_highway_and_building; /* avoids duplicate warnings with following rule */
   throwWarning: tr("node connects highway and building");
 }