Changeset 16643 in josm for trunk/src/org/openstreetmap/josm/gui/io

Timestamp:

2020-06-14T20:19:59+02:00 (4 years ago)

Author:

simon04

Message:

see #19334 - ​https://errorprone.info/bugpattern/StringSplitter

Location:

trunk/src/org/openstreetmap/josm/gui/io

Files:

• ChangesetCommentModel.java (modified) (1 diff)
• CustomConfigurator.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/io/ChangesetCommentModel.java

@@ -46 +46 @@
      */
     public List<String> findHashTags() {
-        return Arrays.stream(comment.split("\\s"))
+        return Arrays.stream(comment.split("\\s", -1))
                 .map(s -> Utils.strip(s, ",;"))
                 .filter(s -> s.matches("#[a-zA-Z][a-zA-Z_\\-0-9]+"))

trunk/src/org/openstreetmap/josm/gui/io/CustomConfigurator.java

@@ -170 +170 @@
         if (!opts.isEmpty()) {
             return JOptionPane.showOptionDialog(MainApplication.getMainFrame(), text, "Question",
-                    JOptionPane.YES_NO_CANCEL_OPTION, JOptionPane.QUESTION_MESSAGE, null, opts.split(";"), 0);
+                    JOptionPane.YES_NO_CANCEL_OPTION, JOptionPane.QUESTION_MESSAGE, null, opts.split(";", -1), 0);
         } else {
             return JOptionPane.showOptionDialog(MainApplication.getMainFrame(), text, "Question",
@@ -298 +298 @@
         final List<String> removeList = new ArrayList<>();
         final List<String> deleteList = new ArrayList<>();
-        Collections.addAll(installList, install.toLowerCase(Locale.ENGLISH).split(";"));
-        Collections.addAll(removeList, uninstall.toLowerCase(Locale.ENGLISH).split(";"));
-        Collections.addAll(deleteList, delete.toLowerCase(Locale.ENGLISH).split(";"));
+        Collections.addAll(installList, install.toLowerCase(Locale.ENGLISH).split(";", -1));
+        Collections.addAll(removeList, uninstall.toLowerCase(Locale.ENGLISH).split(";", -1));
+        Collections.addAll(deleteList, delete.toLowerCase(Locale.ENGLISH).split(";", -1));
         installList.remove("");
         removeList.remove("");