Changeset 16509 in josm for trunk/src/org/openstreetmap/josm/actions/JumpToAction.java

Timestamp:

2020-05-27T11:16:39+02:00 (4 years ago)

Author:

GerdP

Message:

see #19296: Actions should avoid to install listeners which are not needed

• either don't call installAdapters() or overwrite listenToSelectionChange()
• partly reverts previous changes so that installAdapters() is not overwritten

One has to be careful because installAdapters() also calls initEnabledState()

File:

• trunk/src/org/openstreetmap/josm/actions/JumpToAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/JumpToAction.java

@@ -56 +56 @@
         super(tr("Jump to Position"), (ImageProvider) null, tr("Opens a dialog that allows to jump to a specific location"),
                 Shortcut.registerShortcut("tools:jumpto", tr("Tool: {0}", tr("Jump to Position")),
-                        KeyEvent.VK_J, Shortcut.CTRL), true, "action/jumpto", true);
+                        KeyEvent.VK_J, Shortcut.CTRL), true, "action/jumpto", false);
+        // make this action listen to mapframe change events
+        MainApplication.addMapFrameListener((o, n) -> updateEnabledState());
+
         setHelpId(ht("/Action/JumpToPosition"));
     }
@@ -242 +245 @@
         setEnabled(MainApplication.isDisplayingMapView());
     }
-
-    @Override
-    protected void installAdapters() {
-        super.installAdapters();
-        // make this action listen to mapframe change events
-        MainApplication.addMapFrameListener((o, n) -> updateEnabledState());
-    }
 }