Changeset 16438 in josm for trunk/src/org/openstreetmap/josm/actions/upload/UploadNotesTask.java

Timestamp:

2020-05-17T14:18:22+02:00 (4 years ago)

Author:

simon04

Message:

see #19251 - Java 8: use Stream

File:

• trunk/src/org/openstreetmap/josm/actions/upload/UploadNotesTask.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/UploadNotesTask.java

@@ -7 +7 @@
 import java.util.HashMap;
 import java.util.Map;
+import java.util.stream.Collectors;
 
 import javax.swing.JOptionPane;
@@ -124 +125 @@
             noteData.updateNotes(updatedNotes);
             if (!failedNotes.isEmpty()) {
-                StringBuilder sb = new StringBuilder();
-                for (Map.Entry<Note, Exception> entry : failedNotes.entrySet()) {
-                    sb.append(tr("Note {0} failed: {1}", entry.getKey().getId(), entry.getValue().getMessage()))
-                      .append('\n');
-                }
-                Logging.error("Notes failed to upload: " + sb.toString());
-                JOptionPane.showMessageDialog(MainApplication.getMap(), sb.toString(),
+                String message = failedNotes.entrySet().stream()
+                        .map(entry -> tr("Note {0} failed: {1}", entry.getKey().getId(), entry.getValue().getMessage()))
+                        .collect(Collectors.joining("\n"));
+                Logging.error("Notes failed to upload: " + message);
+                JOptionPane.showMessageDialog(MainApplication.getMap(), message,
                         tr("Notes failed to upload"), JOptionPane.ERROR_MESSAGE);
                 ExceptionDialogUtil.explainException(failedNotes.values().iterator().next());