Changeset 1614 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2009-05-23T21:54:50+02:00 (15 years ago)

Author:

stoecker

Message:

fix #2642 - patch by Teemu Koskinen - TagCorrector didn't work properly when a way has multiple roles in one relation

Location:

trunk/src/org/openstreetmap/josm/corrector

Files:

• ReverseWayTagCorrector.java (modified) (2 diffs)
• RoleCorrection.java (modified) (1 diff)
• TagCorrector.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java

@@ -112 +112 @@
 
         for (Relation relation : Main.ds.relations) {
+            int position = 0;
             for (RelationMember member : relation.members) {
                 if (!member.member.realEqual(oldway, true)
-                        || member.role.length() == 0)
+                        || member.role.length() == 0) {
+                    position++;
                     continue;
+                }
 
                 boolean found = false;
@@ -129 +132 @@
                 if (found)
                     roleCorrectionMap.get(way).add(
-                            new RoleCorrection(relation, member, newRole));
+                            new RoleCorrection(relation, position, member, newRole));
+
+                position++;
             }
         }

trunk/src/org/openstreetmap/josm/corrector/RoleCorrection.java

@@ -8 +8 @@
 
     public final Relation relation;
+    public final int position;
     public final RelationMember member;
     public final String newRole;
 
-    public RoleCorrection(Relation relation, RelationMember member,
-            String newRole) {
+    public RoleCorrection(Relation relation, int position,
+                          RelationMember member, String newRole) {
         this.relation = relation;
+        this.position = position;
         this.member = member;
         this.newRole = newRole;

trunk/src/org/openstreetmap/josm/corrector/TagCorrector.java

@@ -168 +168 @@
                     List<RoleCorrection> roleCorrections = roleCorrectionMap
                             .get(primitive);
-                    for (int i = 0; i < roleCorrections.size(); i++) {
-                        if (roleTableMap.get(primitive)
-                                .getCorrectionTableModel().getApply(i)) {
-                            RoleCorrection roleCorrection = roleCorrections
-                                    .get(i);
-                            Relation newRelation = new Relation(
-                                    roleCorrection.relation);
-                            for (RelationMember member : newRelation.members)
-                                if (member.equals(roleCorrection.member))
+                    for (Relation relation : Main.ds.relations) {
+                        Relation newRelation = new Relation(relation);
+                        Boolean changed = false;
+
+                        for (int i = 0; i < roleCorrections.size(); i++) {
+                            RoleCorrection roleCorrection = roleCorrections.get(i);
+                            if (roleCorrection.relation == relation &&
+                                    roleTableMap.get(primitive).getCorrectionTableModel().getApply(i)) {
+
+                                RelationMember member = newRelation.members.get(roleCorrection.position);
+
+                                if (member.equals(roleCorrection.member)) {
                                     member.role = roleCorrection.newRole;
-                            commands.add(new ChangeCommand(
-                                    roleCorrection.relation, newRelation));
+                                    changed = true;
+                                }
+                            }
                         }
+                        if (changed)
+                            commands.add(new ChangeCommand(relation, newRelation));
                     }
                 }