Changeset 16088 in josm for trunk/src/org/openstreetmap/josm/io/ValidatorErrorWriter.java

Timestamp:

2020-03-08T20:15:37+01:00 (4 years ago)

Author:

Don-vip

Message:

fix #18853 - Close OsmWriter after writing XML output streams (patch by hiddewie, modified)

File:

• trunk/src/org/openstreetmap/josm/io/ValidatorErrorWriter.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/io/ValidatorErrorWriter.java

@@ -3 +3 @@
 
 import java.io.BufferedWriter;
+import java.io.IOException;
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
@@ -60 +61 @@
      * Write validator errors to designated output target
      * @param validationErrors Test error collection to write
+     * @throws IOException in case of I/O error
      */
-    public void write(Collection<TestError> validationErrors) {
+    public void write(Collection<TestError> validationErrors) throws IOException {
         Set<Test> analysers = validationErrors.stream().map(TestError::getTester).collect(Collectors.toCollection(TreeSet::new));
         String timestamp = DateUtils.fromDate(new Date());
@@ -68 +70 @@
         out.println("<analysers generator='JOSM' timestamp='"+timestamp+"'>");
 
-        OsmWriter osmWriter = OsmWriterFactory.createOsmWriter(out, true, OsmChangeBuilder.DEFAULT_API_VERSION);
-        String lang = LanguageInfo.getJOSMLocaleCode();
+        try (OsmWriter osmWriter = OsmWriterFactory.createOsmWriter(out, true, OsmChangeBuilder.DEFAULT_API_VERSION)) {
+            String lang = LanguageInfo.getJOSMLocaleCode();
 
-        for (Test test : analysers) {
-            out.println("  <analyser timestamp='"+timestamp+"' name='"+XmlWriter.encode(test.getName())+"'>");
-            // Build map of test error classes for the current test
-            Map<ErrorClass, List<TestError>> map = new HashMap<>();
-            for (Entry<Severity, Map<String, Map<String, List<TestError>>>> e1 :
-                OsmValidator.getErrorsBySeverityMessageDescription(validationErrors, e -> e.getTester() == test).entrySet()) {
-                for (Entry<String, Map<String, List<TestError>>> e2 : e1.getValue().entrySet()) {
-                    ErrorClass errorClass = new ErrorClass(e1.getKey(), e2.getKey());
-                    List<TestError> list = map.get(errorClass);
-                    if (list == null) {
-                        list = new ArrayList<>();
-                        map.put(errorClass, list);
+            for (Test test : analysers) {
+                out.println("  <analyser timestamp='" + timestamp + "' name='" + XmlWriter.encode(test.getName()) + "'>");
+                // Build map of test error classes for the current test
+                Map<ErrorClass, List<TestError>> map = new HashMap<>();
+                for (Entry<Severity, Map<String, Map<String, List<TestError>>>> e1 :
+                        OsmValidator.getErrorsBySeverityMessageDescription(validationErrors, e -> e.getTester() == test).entrySet()) {
+                    for (Entry<String, Map<String, List<TestError>>> e2 : e1.getValue().entrySet()) {
+                        ErrorClass errorClass = new ErrorClass(e1.getKey(), e2.getKey());
+                        List<TestError> list = map.get(errorClass);
+                        if (list == null) {
+                            list = new ArrayList<>();
+                            map.put(errorClass, list);
+                        }
+                        e2.getValue().values().forEach(list::addAll);
                     }
-                    e2.getValue().values().forEach(list::addAll);
                 }
+                // Write classes
+                for (ErrorClass ec : map.keySet()) {
+                    out.println("    <class id='" + ec.id + "' level='" + ec.severity.getLevel() + "'>");
+                    out.println("      <classtext lang='" + XmlWriter.encode(lang) + "' title='" + XmlWriter.encode(ec.message) + "'/>");
+                    out.println("    </class>");
+                }
+
+                // Write errors
+                for (Entry<ErrorClass, List<TestError>> entry : map.entrySet()) {
+                    for (TestError error : entry.getValue()) {
+                        LatLon ll = error.getPrimitives().iterator().next().getBBox().getCenter();
+                        out.println("    <error class='" + entry.getKey().id + "'>");
+                        out.print("      <location");
+                        osmWriter.writeLatLon(ll);
+                        out.println("/>");
+                        for (OsmPrimitive p : error.getPrimitives()) {
+                            p.accept(osmWriter);
+                        }
+                        out.println("      <text lang='" + XmlWriter.encode(lang) +
+                                "' value='" + XmlWriter.encode(error.getDescription()) + "'/>");
+                        if (error.isFixable()) {
+                            out.println("      <fixes>");
+                            Command fix = error.getFix();
+                            if (fix instanceof AddPrimitivesCommand) {
+                                Logging.info("TODO: {0}", fix);
+                            } else if (fix instanceof DeleteCommand) {
+                                Logging.info("TODO: {0}", fix);
+                            } else if (fix instanceof ChangePropertyCommand) {
+                                Logging.info("TODO: {0}", fix);
+                            } else if (fix instanceof ChangePropertyKeyCommand) {
+                                Logging.info("TODO: {0}", fix);
+                            } else {
+                                Logging.warn("Unsupported command type: {0}", fix);
+                            }
+                            out.println("      </fixes>");
+                        }
+                        out.println("    </error>");
+                    }
+                }
+
+                out.println("  </analyser>");
             }
-            // Write classes
-            for (ErrorClass ec : map.keySet()) {
-                out.println("    <class id='"+ec.id+"' level='"+ec.severity.getLevel()+"'>");
-                out.println("      <classtext lang='"+XmlWriter.encode(lang)+"' title='"+XmlWriter.encode(ec.message)+"'/>");
-                out.println("    </class>");
-            }
-
-            // Write errors
-            for (Entry<ErrorClass, List<TestError>> entry : map.entrySet()) {
-                for (TestError error : entry.getValue()) {
-                    LatLon ll = error.getPrimitives().iterator().next().getBBox().getCenter();
-                    out.println("    <error class='"+entry.getKey().id+"'>");
-                    out.print("      <location");
-                    osmWriter.writeLatLon(ll);
-                    out.println("/>");
-                    for (OsmPrimitive p : error.getPrimitives()) {
-                        p.accept(osmWriter);
-                    }
-                    out.println("      <text lang='"+XmlWriter.encode(lang)+"' value='"+XmlWriter.encode(error.getDescription())+"'/>");
-                    if (error.isFixable()) {
-                        out.println("      <fixes>");
-                        Command fix = error.getFix();
-                        if (fix instanceof AddPrimitivesCommand) {
-                            Logging.info("TODO: {0}", fix);
-                        } else if (fix instanceof DeleteCommand) {
-                            Logging.info("TODO: {0}", fix);
-                        } else if (fix instanceof ChangePropertyCommand) {
-                            Logging.info("TODO: {0}", fix);
-                        } else if (fix instanceof ChangePropertyKeyCommand) {
-                            Logging.info("TODO: {0}", fix);
-                        } else {
-                            Logging.warn("Unsupported command type: {0}", fix);
-                        }
-                        out.println("      </fixes>");
-                    }
-                    out.println("    </error>");
-                }
-            }
-
-            out.println("  </analyser>");
         }