Changeset 1560 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2009-04-27T23:49:19+02:00 (15 years ago)

Author:

framm

Message:

• "learn" new version numbers on repeated download

File:

• trunk/src/org/openstreetmap/josm/data/osm/visitor/MergeVisitor.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/data/osm/visitor/MergeVisitor.java

@@ -58 +58 @@
             HashMap<Long, P> primhash) {
         // 1. Try to find an identical prim with the same id.
-        if (mergeAfterId(myprims, primhash, other))
+        if (mergeById(myprims, primhash, other))
             return;
 
@@ -200 +200 @@
                 my.id = other.id;
                 my.modified = other.modified; // match a new node
+                my.version = other.version;
             } else if (my.id != 0 && other.id != 0 && other.modified)
                 my.modified = true;
@@ -218 +219 @@
      * @return <code>true</code>, if no merge is needed or merge is performed already.
      */
-    private <P extends OsmPrimitive> boolean mergeAfterId(
+    private <P extends OsmPrimitive> boolean mergeById(
             Collection<P> primitives, HashMap<Long, P> hash, P other) {
         // Fast-path merging of identical objects
@@ -235 +236 @@
             }
             if (my.realEqual(other, true)) {
-                Date myd = my.getTimestamp();
-                Date otherd = other.getTimestamp();
-
-                // they differ in modified/timestamp combination only. Auto-resolve it.
-                merged.put(other, my);
-                if (myd.before(otherd)) {
+                // they differ in modified/version combination only. Auto-resolve it.
+                merged.put(other, my);
+                if (my.version < other.version) {
+                    my.version = other.version;
                     my.modified = other.modified;
                     my.setTimestamp(other.getTimestamp());
@@ -247 +246 @@
             }
             if (my.id == other.id && my.id != 0) {
-                Date myd = my.getTimestamp();
-                Date otherd = other.getTimestamp();
-
                 if (my.incomplete || other.incomplete) {
                     if (my.incomplete) {
@@ -257 +253 @@
                     conflicts.put(my, other);
                 } else if (!my.modified && !other.modified) {
-                    if (myd.before(otherd)) {
+                    if (my.version < other.version) {
                         my.cloneFrom(other);
                     }
                 } else if (other.modified) {
-                    if (myd.after(otherd)) {
+                    if (my.version > other.version) {
                         conflicts.put(my, other);
                     } else {
@@ -267 +263 @@
                     }
                 } else if (my.modified) {
-                    if (myd.before(otherd)) {
+                    if (my.version < other.version) {
                         conflicts.put(my, other);
                     }