Changeset 14977 in josm for trunk/src/org/openstreetmap/josm/tools/Utils.java

Timestamp:

2019-04-09T01:32:56+02:00 (5 years ago)

Author:

Don-vip

Message:

ensures consistency of upload comment:

• fix #11168 - ctrl-z/undo could reset unwanted old changeset comment
• fix #13474 - selecting "new changeset" after having entered a changeset comment did reset it to the previous value
• fix #17452 - ctrl-enter while typing a changeset comment did upload with the previous value
• fix behaviour of upload.comment.max-age: values were reset after 5 months instead of intended 4 hours because seconds were compared to milliseconds
• avoid creation of unneeded undo/redo internal classes for non-editable text fields
• ensures consistency of upload dialog if upload.comment properties are modified manually from advanced preferences
• add a source attribute to preference events to know which class modified the preference entry
• refactor reflection utils

File:

• trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -30 +30 @@
 import java.nio.file.attribute.BasicFileAttributes;
 import java.nio.file.attribute.FileTime;
-import java.security.AccessController;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
-import java.security.PrivilegedAction;
 import java.text.Bidi;
 import java.text.DateFormat;
@@ -1559 +1557 @@
      * @param objects objects
      * @see AccessibleObject#setAccessible
+     * @deprecated Use {@link ReflectionUtils#setObjectsAccessible(AccessibleObject...)}
      * @since 10223
      */
+    @Deprecated
     public static void setObjectsAccessible(final AccessibleObject... objects) {
-        if (objects != null && objects.length > 0) {
-            AccessController.doPrivileged((PrivilegedAction<Object>) () -> {
-                for (AccessibleObject o : objects) {
-                    if (o != null) {
-                        o.setAccessible(true);
-                    }
-                }
-                return null;
-            });
-        }
+        ReflectionUtils.setObjectsAccessible(objects);
     }