Changeset 14977 in josm for trunk/src/org/openstreetmap/josm/spi/preferences/DefaultPreferenceChangeEvent.java

Timestamp:

2019-04-09T01:32:56+02:00 (5 years ago)

Author:

Don-vip

Message:

ensures consistency of upload comment:

• fix #11168 - ctrl-z/undo could reset unwanted old changeset comment
• fix #13474 - selecting "new changeset" after having entered a changeset comment did reset it to the previous value
• fix #17452 - ctrl-enter while typing a changeset comment did upload with the previous value
• fix behaviour of upload.comment.max-age: values were reset after 5 months instead of intended 4 hours because seconds were compared to milliseconds
• avoid creation of unneeded undo/redo internal classes for non-editable text fields
• ensures consistency of upload dialog if upload.comment properties are modified manually from advanced preferences
• add a source attribute to preference events to know which class modified the preference entry
• refactor reflection utils

File:

• trunk/src/org/openstreetmap/josm/spi/preferences/DefaultPreferenceChangeEvent.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/spi/preferences/DefaultPreferenceChangeEvent.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.spi.preferences;
+
+import java.util.EventObject;
 
 /**
@@ -6 +8 @@
  * @since 12881
  */
-public class DefaultPreferenceChangeEvent implements PreferenceChangeEvent {
-    
+public class DefaultPreferenceChangeEvent extends EventObject implements PreferenceChangeEvent {
+
     private final String key;
     private final Setting<?> oldValue;
     private final Setting<?> newValue;
 
-    public DefaultPreferenceChangeEvent(String key, Setting<?> oldValue, Setting<?> newValue) {
+    /**
+     * Constructs a new {@code DefaultPreferenceChangeEvent}.
+     * @param source the class source of this event
+     * @param key preference key
+     * @param oldValue preference old value
+     * @param newValue preference new value
+     * @since 14977
+     */
+    public DefaultPreferenceChangeEvent(Class<?> source, String key, Setting<?> oldValue, Setting<?> newValue) {
+        super(source);
         this.key = key;
         this.oldValue = oldValue;
         this.newValue = newValue;
+    }
+
+    @Override
+    public Class<?> getSource() {
+        return (Class<?>) super.getSource();
     }
 
@@ -32 +48 @@
         return newValue;
     }
-    
+
 }