Changeset 14933 in josm for trunk/test/unit/org/openstreetmap/josm/data

Timestamp:

2019-03-26T01:58:41+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #15645, fix #17521 - Detect and fix non-printing control characters

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java

@@ -248 +248 @@
     }
 
+    /**
+     * Unit test of {@link TagChecker#removeNonPrintingControlCharacters}
+     */
+    @Test
+    public void testRemoveUnprintableControlCharacters() {
+        // Check 65 ASCII control characters are removed, except new lines
+        for (char c = 0x0; c < 0x20; c++) {
+            if (c != '\r' && c != '\n') {
+                assertTrue(TagChecker.removeNonPrintingControlCharacters(Character.toString(c)).isEmpty());
+            } else {
+                assertFalse(TagChecker.removeNonPrintingControlCharacters(Character.toString(c)).isEmpty());
+            }
+        }
+        assertTrue(TagChecker.removeNonPrintingControlCharacters(Character.toString((char) 0x7F)).isEmpty());
+        // Check 9 Unicode bidi control characters are removed
+        for (char c = 0x200c; c <= 0x200f; c++) {
+            assertTrue(TagChecker.removeNonPrintingControlCharacters(Character.toString(c)).isEmpty());
+        }
+        for (char c = 0x202a; c <= 0x202e; c++) {
+            assertTrue(TagChecker.removeNonPrintingControlCharacters(Character.toString(c)).isEmpty());
+        }
+    }
 }