Changeset 14931 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java

Timestamp:

2019-03-25T18:53:02+01:00 (5 years ago)

Author:

GerdP

Message:

see #17469: Fix memory leak: destroy JosmAction

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java

@@ -102 +102 @@
     /** The lookup action */
     private final transient LookupAction lookupAction;
+    private final transient JosmAction ignoreForNowAction;
 
     private final JPopupMenu popupMenu = new JPopupMenu();
@@ -123 +124 @@
         InputMapUtils.unassignCtrlShiftUpDown(tree, JComponent.WHEN_FOCUSED);
 
-        JosmAction ignoreForNowAction = new JosmAction(tr("Ignore for now"), "dialogs/delete",
+        ignoreForNowAction = new JosmAction(tr("Ignore for now"), "dialogs/delete",
                 tr("Ignore and remove from tree."), Shortcut.registerShortcut("tools:validate:ignore-for-now",
                         tr("Ignore and remove from tree."), KeyEvent.VK_MINUS, Shortcut.SHIFT),
@@ -735 +736 @@
         }
     }
+
+    @Override
+    public void destroy() {
+        super.destroy();
+        if (ignoreForNowAction != null) {
+            ignoreForNowAction.destroy();
+        }
+    }
 }