Changeset 14517 in josm for trunk/test/unit/org/openstreetmap/josm/data/validation

Timestamp:

2018-12-06T10:55:42+01:00 (5 years ago)

Author:

GerdP

Message:

see #17055 improve TagChecker

• don't suggest fix value when given value is short and Levenshtein distance is 2

surface=u should not be fixed with surface=mud but highway=tra can be fixed with highway=track

File:

• trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java

@@ -138 +138 @@
         assertTrue(errors.get(0).isFixable());
     }
+
     /**
      * Check for misspelled value.
@@ -167 +168 @@
         assertTrue(errors.toString(), errors.isEmpty());
     }
+
+    /**
+     * Check regression: Don't fix surface=u -> surface=mud.
+     * @throws IOException if any I/O error occurs
+     */
+    @Test
+    public void testTooShortToFix() throws IOException {
+        final List<TestError> errors = test(OsmUtils.createPrimitive("node surface=u"));
+        assertEquals(1, errors.size());
+        assertEquals("Presets do not contain property value", errors.get(0).getMessage());
+        assertEquals("Value 'u' for key 'surface' not in presets.", errors.get(0).getDescription());
+        assertEquals(Severity.OTHER, errors.get(0).getSeverity());
+        assertFalse(errors.get(0).isFixable());
+    }
+
+    /**
+     * Check value with upper case
+     * @throws IOException if any I/O error occurs
+     */
+    @Test
+    public void testValueDifferentCase() throws IOException {
+        final List<TestError> errors = test(OsmUtils.createPrimitive("node highway=Residential"));
+        assertEquals(1, errors.size());
+        assertEquals("Misspelled property value", errors.get(0).getMessage());
+        assertEquals("Value 'Residential' for key 'highway' looks like 'residential'.", errors.get(0).getDescription());
+        assertEquals(Severity.WARNING, errors.get(0).getSeverity());
+        assertTrue(errors.get(0).isFixable());
+    }
+
 }