Changeset 14463 in josm for trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowser.java

Timestamp:

2018-11-28T22:42:32+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #17040 - fix memory leaks when calling history dialog

File:

• trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowser.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowser.java

@@ -15 +15 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
 import org.openstreetmap.josm.data.osm.history.History;
+import org.openstreetmap.josm.tools.Destroyable;
 
 /**
  * HistoryBrowser is an UI component which displays history information about an {@link OsmPrimitive}.
  *
- *
+ * @since 1709
  */
-public class HistoryBrowser extends JPanel {
+public class HistoryBrowser extends JPanel implements Destroyable {
 
     /** the model */
@@ -106 +107 @@
     }
 
-
     /**
      * populates the browser with the history of a specific {@link OsmPrimitive}
@@ -149 +149 @@
         return model;
     }
+
+    @Override
+    public void destroy() {
+        model.unlinkAsListener();
+        for (Destroyable component : new Destroyable[] {
+                tagInfoViewer, nodeListViewer, relationMemberListViewer, coordinateInfoViewer}) {
+            component.destroy();
+        }
+    }
 }