Changeset 14412 in josm for trunk/test/unit/org/openstreetmap/josm/gui/help

Timestamp:

2018-11-05T01:16:59+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #16946, fix #16947 - unit test fixes for non-headless mode (patch by ris)

File:

• trunk/test/unit/org/openstreetmap/josm/gui/help/HelpBrowserTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/help/HelpBrowserTest.java

@@ -13 +13 @@
 import org.openstreetmap.josm.testutils.mockers.JOptionPaneSimpleMocker;
 import org.openstreetmap.josm.tools.LanguageInfo.LocaleType;
+import org.openstreetmap.josm.tools.PlatformHook;
+import org.openstreetmap.josm.tools.PlatformManager;
 
 import com.google.common.collect.ImmutableMap;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import mockit.Expectations;
+import mockit.Injectable;
 
 /**
@@ -91 +95 @@
 
     /**
-     * Unit test of {@link HelpBrowser.EditAction} class.
-     */
-    @Test
-    public void testEditAction() {
-        TestUtils.assumeWorkingJMockit();
+     * Unit test of {@link HelpBrowser.EditAction} class handling a null url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionNull(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook; minTimes = 0;
+        }};
+        new Expectations() {{
+            // should not be called
+            mockPlatformHook.openUrl((String) any); times = 0;
+        }};
+
         IHelpBrowser browser = newHelpBrowser();
         assertNull(browser.getUrl());
         new HelpBrowser.EditAction(browser).actionPerformed(null);
-
+    }
+
+    /**
+     * Unit test of {@link HelpBrowser.EditAction} class handling an "internal" url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionInternal(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook;
+        }};
+        new Expectations() {{
+            mockPlatformHook.openUrl(URL_2 + "?action=edit"); result = null; times = 1;
+        }};
+
+        IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_2);
         assertEquals(URL_2, browser.getUrl());
         new HelpBrowser.EditAction(browser).actionPerformed(null);
-
+    }
+
+    /**
+     * Unit test of {@link HelpBrowser.EditAction} class handling an "external" url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionExternal(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook; minTimes = 0;
+        }};
+        new Expectations() {{
+            // should not be called
+            mockPlatformHook.openUrl((String) any); times = 0;
+        }};
         final JOptionPaneSimpleMocker jopsMocker = new JOptionPaneSimpleMocker(
             ImmutableMap.<String, Object>of(
@@ -113 +160 @@
         );
 
+        IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_3);
         assertEquals(URL_3, browser.getUrl());
@@ -125 +173 @@
     /**
      * Unit test of {@link HelpBrowser.OpenInBrowserAction} class.
-     */
-    @Test
-    public void testOpenInBrowserAction() {
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testOpenInBrowserAction(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook;
+        }};
+        new Expectations() {{
+            mockPlatformHook.openUrl(URL_1); result = null; times = 1;
+        }};
+
         IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_1);