Changeset 14402 in josm for trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

Timestamp:

2018-11-02T18:07:31+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #16938 - improve performance when data contains ways with many nodes (patch by GerdP, modified)

File:

• trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

@@ -1298 +1298 @@
             boolean useSelected, Collection<OsmPrimitive> preferredRefs) {
         WaySegment wayseg = null;
-        WaySegment ntsel = null;
-        WaySegment ntref = null;
         if (preferredRefs != null && preferredRefs.isEmpty())
             preferredRefs = null;
 
-        searchLoop: for (List<WaySegment> wslist : getNearestWaySegmentsImpl(p, predicate).values()) {
+        for (List<WaySegment> wslist : getNearestWaySegmentsImpl(p, predicate).values()) {
             for (WaySegment ws : wslist) {
                 if (wayseg == null) {
                     wayseg = ws;
                 }
-                if (ntsel == null && ws.way.isSelected()) {
-                    ntsel = ws;
-                    break searchLoop;
-                }
-                if (ntref == null && preferredRefs != null) {
+                if (useSelected && ws.way.isSelected()) {
+                    return ws;
+                }
+                if (preferredRefs != null && !preferredRefs.isEmpty()) {
                     // prefer ways containing given nodes
-                    for (Node nd: ws.way.getNodes()) {
-                        if (preferredRefs.contains(nd)) {
-                            ntref = ws;
-                            break searchLoop;
-                        }
+                    if (preferredRefs.contains(ws.getFirstNode()) || preferredRefs.contains(ws.getSecondNode())) {
+                        return ws;
                     }
                     Collection<OsmPrimitive> wayRefs = ws.way.getReferrers();
@@ -1324 +1318 @@
                     for (OsmPrimitive ref: preferredRefs) {
                         if (ref instanceof Relation && wayRefs.contains(ref)) {
-                            ntref = ws;
-                            break searchLoop;
+                            return ws;
                         }
                     }
@@ -1331 +1324 @@
             }
         }
-        if (ntsel != null && useSelected)
-            return ntsel;
-        if (ntref != null)
-            return ntref;
         return wayseg;
     }