Changeset 14214 in josm for trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java

Timestamp:

2018-09-01T15:29:15+02:00 (6 years ago)

Author:

Don-vip

Message:

sonarqube - squid:S4551 - Enum values should be compared with "=="

File:

• trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java

@@ -213 +213 @@
     public boolean hasUnsavedData() {
         for (SaveLayerInfo info: layerInfo) {
-            if (info.isDoUploadToServer() && !UploadOrSaveState.OK.equals(info.getUploadState()))
+            if (info.isDoUploadToServer() && UploadOrSaveState.OK != info.getUploadState())
                 return true;
-            if (info.isDoSaveToFile() && !UploadOrSaveState.OK.equals(info.getSaveState()))
+            if (info.isDoSaveToFile() && UploadOrSaveState.OK != info.getSaveState())
                 return true;
         }
@@ -224 +224 @@
         int ret = 0;
         for (SaveLayerInfo info: layerInfo) {
-            if (UploadOrSaveState.CANCELED.equals(info.getSaveState())
-                    || UploadOrSaveState.CANCELED.equals(info.getUploadState())) {
+            if (UploadOrSaveState.CANCELED == info.getSaveState()
+                    || UploadOrSaveState.CANCELED == info.getUploadState()) {
                 ret++;
             }
@@ -235 +235 @@
         int ret = 0;
         for (SaveLayerInfo info: layerInfo) {
-            if (UploadOrSaveState.FAILED.equals(info.getSaveState())
-                    || UploadOrSaveState.FAILED.equals(info.getUploadState())) {
+            if (UploadOrSaveState.FAILED == info.getSaveState()
+                    || UploadOrSaveState.FAILED == info.getUploadState()) {
                 ret++;
             }