Changeset 14201 in josm for trunk/test/unit/org/openstreetmap/josm/gui/preferences/map

Timestamp:

2018-08-29T19:40:53+02:00 (6 years ago)

Author:

Don-vip

Message:

spotbugs - fix various issues found with Eclipse plugin

File:

• trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/MapPaintPreferenceTestIT.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/MapPaintPreferenceTestIT.java

@@ -6 +6 @@
 
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
@@ -84 +83 @@
                     }
                 }
-                if (style != null) {
-                    System.out.println(style.isValid() ? " => OK" : " => KO");
-                    Collection<Throwable> errors = style.getErrors();
-                    Collection<String> warnings = style.getWarnings();
-                    if (!errors.isEmpty()) {
-                        allErrors.put(source.url, errors);
-                    }
-                    if (!warnings.isEmpty()) {
-                        allWarnings.put(source.url, warnings);
-                    }
-                } else {
-                    allWarnings.put(source.url, Collections.singleton("MapPaintStyles.addStyle() returned null"));
+                System.out.println(style.isValid() ? " => OK" : " => KO");
+                Collection<Throwable> errors = style.getErrors();
+                Collection<String> warnings = style.getWarnings();
+                if (!errors.isEmpty()) {
+                    allErrors.put(source.url, errors);
+                }
+                if (!warnings.isEmpty()) {
+                    allWarnings.put(source.url, warnings);
                 }
             }