Changeset 14201 in josm for trunk/test/unit/org/openstreetmap/josm/actions

Timestamp:

2018-08-29T19:40:53+02:00 (6 years ago)

Author:

Don-vip

Message:

spotbugs - fix various issues found with Eclipse plugin

File:

• trunk/test/unit/org/openstreetmap/josm/actions/downloadtasks/PluginDownloadTaskTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/downloadtasks/PluginDownloadTaskTest.java

@@ -9 +9 @@
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
+import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 
@@ -35 +36 @@
     @Rule
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().https().assumeRevision(
+    public JOSMTestRules testRule = new JOSMTestRules().https().assumeRevision(
         "Revision: 8000\n"
     ).preferences();
@@ -68 +69 @@
         // put existing "plugin file" in place
         pluginFile.getParentFile().mkdirs();
-        final byte[] existingPluginContents = "Existing plugin contents 123".getBytes();
+        final byte[] existingPluginContents = "Existing plugin contents 123".getBytes(StandardCharsets.UTF_8);
         try (FileOutputStream existingPluginOutputStream = new FileOutputStream(pluginFile)) {
             existingPluginOutputStream.write(existingPluginContents);
@@ -111 +112 @@
 
         pluginFile.getParentFile().mkdirs();
-        final byte[] existingPluginContents = "Existing plugin contents 123".getBytes();
+        final byte[] existingPluginContents = "Existing plugin contents 123".getBytes(StandardCharsets.UTF_8);
         try (FileOutputStream existingPluginOutputStream = new FileOutputStream(pluginFile)) {
             existingPluginOutputStream.write(existingPluginContents);